bugGNU Octave - Bugs: bug #65528, (nurbs) should include...

 
 

bug #65528: (nurbs) should include <cassert>

Submitter:  Dmitri A. Sergatskov <dasergatskov>
Submitted:  Thu 28 Mar 2024 07:11:40 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Patch Submitted Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 28 Mar 2024 07:24:28 PM UTC, comment #1: 

CC'ing package maintainers.

The attached patch makes it compile in MXE Octave:
https://hg.octave.org/mxe-octave/file/tip/src/of-nurbs-1-cassert.patch

(file #55896)

Markus Mützel <mmuetzel>
Group administrator
Thu 28 Mar 2024 07:11:40 PM UTC, original submission:  

Compiling on Octave 10 (dev):

/usr/local/bin/mkoctfile-10.0.0 --verbose -c low_level_functions.cc
g++ -std=gnu++17 -c  -fPIC -I/usr/local/include/octave-10.0.0/octave/.. -I/usr/local/include/octave-10.0.0/octave -I/usr/local/include  -pthread -fopenmp -ggdb3 -O2 -march=native -mtune=native -mavx -mavx2 -flto=auto    low_level_functions.cc -o low_level_functions.o
low_level_functions.cc: In function ‘int surfderivcpts(octave_idx_type, octave_idx_type, const RowVector&, octave_idx_type, octave_idx_type, const RowVector&, const Matrix&, octave_idx_type, octave_idx_type, octave_idx_type, octave_idx_type, octave_idx_type, NDArray&)’:
low_level_functions.cc:292:15: error: ‘assert’ was not declared in this scope
  292 |               assert (k<idxa(0) && i<idxa(2) && j-s1<idxa(3));
      |               ^~~~~~
low_level_functions.cc:23:1: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
   22 | #include <iostream>
  +++ |+#include <cassert>
   23 |
low_level_functions.cc:320:19: error: ‘assert’ was not declared in this scope
  320 |                   assert (k<idxa(0) && l<idxa(1)
      |                   ^~~~~~
low_level_functions.cc:320:19: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
make: *** [Makefile:34: low_level_functions.o] Error 1
make: Leaving directory '/tmp/oct-blKnTZ/nurbs-1.4.3/src'


The mxe-octave patch is:
https://hg.octave.org/mxe-octave/rev/ebdff9919577

Discussion:

https://octave.discourse.group/t/assert-panic-error-and-ndebug/5409/20

Dmitri.
--



Dmitri A. Sergatskov <dasergatskov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by dasergatskov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-03-28 mmuetzel Attached File- Added of-nurbs-1-cassert.patch, #55896
        Item GroupNone Build Failure
        StatusNone Patch Submitted
        Carbon-Copy- Added cdf
        Carbon-Copy- Added rafavzqz

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code