bugGNU Octave - Bugs: bug #65030, Column width in browser pane not...

 
 

bug #65030: Column width in browser pane not retained between restarts of Octave

Submitter:  Philip Nienhuis <philipnienhuis>
Submitted:  Wed 13 Dec 2023 08:11:52 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Confirmed Assigned to:  None
Originator Name:  Philip Nienhuis Open/Closed:  * Open
Release:  * stable Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  10.1.0 (current default)
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 04 Feb 2024 04:11:25 PM UTC, comment #9: 

With the patch I get this:


Files dock widget restoring header: 1

GNU Octave, version 10.0.0
Copyright (C) 1993-2024 The Octave Project Developers.
This is free software; see the source code for copying conditions.
:


Philip Nienhuis <philipnienhuis>
Group Member
Sun 04 Feb 2024 01:32:07 PM UTC, comment #8: 

My impression is that the column widths are properly written to file, even read upon restart, but then ignored. But we'll see what your patch shows. It'll try today.

Sort order in the sense of a->z or a<-z, and column order (shifting around column headers) changes are properly retained.

Philip Nienhuis <philipnienhuis>
Group Member
Sun 04 Feb 2024 10:09:57 AM UTC, comment #7: 

Thanks for testing. The column widths are changing on my system at restart when copying your data changes into my ini file. Therefore. the data is okay and definitely reflect changes in column widths. Could you please try the attached patch next time you make a build? With this patch, there is a line in the terminal widget before the welcome message. This line prints out the result of restoring the header state (-1: related key in the settings not found, 0: error while restoring, 1: okay).

There might be a misunderstanding regarding the second item as the sort column and order that you describe are the default ones. When you change the sort order and/or the column, are these changes retained after a restart of octave?

(file #55665)

Torsten Lilge <ttl>
Group Member
Sat 03 Feb 2024 08:02:23 PM UTC, comment #6: 
  • Is the column width in the workspace view restoring the last column width?


No, in the works space column widhts are also reset (good hint, Torsten)

  • Are sort column and sort order preserved in the file browser?


Both column sort and sort order (alphabetically, first subdirs, then filenames, a->z) are retained.

  • Does the line "column_state" in section "[filesdockwidget]" in the settings file change after changing the column with and exiting octave?


Yes these change but the changes seem to be ignored. I copy the relevant lines below, one after a few Octave restarts w/o changing GUI layout, the second one after adapting column width in the file browser pane

column_state=@ByteArray(\0\0\0\xff\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\0\0\0\0\0\x4\x6\0\0\0\x2\0\0\0\x1\0\0\0}\0\0\0\x2\0\0\0}\0\0\x1o\0\0\0\x4\x1\x1\0\x1\0\0\0\0\0\0\0\0\0\0\0\0\x64\xff\xff\xff\xff\0\0\0\x81\0\0\0\0\0\0\0\x4\0\0\0\x64\0\0\0\x1\0\0\0\0\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\x1\v\0\0\0\x1\0\0\0\0\0\0\x3\xe8\0\0\0\0}\0\0\0\0)

column_state=@ByteArray(\0\0\0\xff\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\0\0\0\0\0\x4\x6\0\0\0\x2\0\0\0\x1\0\0\0}\0\0\0\x2\0\0\0}\0\0\x1\x81\0\0\0\x4\x1\x1\0\x1\0\0\0\0\0\0\0\0\0\0\0\0\x64\xff\xff\xff\xff\0\0\0\x81\0\0\0\0\0\0\0\x4\0\0\x1\x4\0\0\0\x1\0\0\0\0\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\0}\0\0\0\x1\0\0\0\0\0\0\x3\xe8\0\0\0\0}\0\0\0\0)



Philip Nienhuis <philipnienhuis>
Group Member
Sat 03 Feb 2024 02:43:10 PM UTC, comment #5: 

I have no windows system for testing available. therefore some questions:

  • Is the column width in the workspace view restoring the last column width?
  • Are sort column and sort order preserved in the file browser?
  • Does the line "column_state" in section "[filesdockwidget]" in the settings file change after changing the column with and exiting octave?


Torsten Lilge <ttl>
Group Member
Sat 03 Feb 2024 12:27:42 AM UTC, comment #4: 

on a fairly recent windows stable build (9.0.1 (hg id: 9034521f154f))  The file browser behaves like shown in the image attached to comment #0. column sizing is not retained after restarting octave

Nicholas Jankowski <nrjank>
Group Member
Fri 02 Feb 2024 10:43:03 PM UTC, comment #3: 

Indeed on Linux there's no issue.

Philip Nienhuis <philipnienhuis>
Group Member
Mon 18 Dec 2023 12:23:45 AM UTC, comment #2: 

I tried to reproduce on Linux, which I run, but the GUI behaves correctly.  Someone with MS Windows will have to check.

Rik <rik5>
Group administrator
Wed 13 Dec 2023 08:14:09 PM UTC, comment #1: 

FTR, in the last dev Octave I made (9.0.0, crossbuilt Nov. 18) this was still working fine.

Philip Nienhuis <philipnienhuis>
Group Member
Wed 13 Dec 2023 08:11:52 PM UTC, original submission:  

See attached pic.
Upper = after starting dev Octave
Lower = after reshifting the column separator line to the right, in vain, as after a restarting Octave the browser pane again looks like the upper pic.

Regression as it used to work fine. But admittedly this is just a cosmetical regression.

Philip Nienhuis <philipnienhuis>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #55665:  bug65030_test_01.patch added by ttl (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by philipnienhuis
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-02-04 ttl Attached File- Added bug65030_test_01.patch, #55665
    2024-02-03 rik5 Carbon-CopyRemoved 72865 -
    2024-02-03 nrjank Releasedev stable
    2024-02-03 nrjank StatusNone Confirmed
    2023-12-18 philipnienhuis Carbon-Copy- Added ttl
    2023-12-13 rik5 SummaryColumn width in browser pane not retianed between restarts of Octave Column width in browser pane not retained between restarts of Octave
    2023-12-13 philipnienhuis Attached File- Added Octave10_filebrowser_colwidth_reset.png, #55449

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code