bugGNU Octave - Bugs: bug #64760, VM Make VM runnable on 32 bit...

 
 

bug #64760: VM Make VM runnable on 32 bit systems

Submitter:  Petter <petter>
Submitted:  Sat 07 Oct 2023 09:00:12 PM UTC
   
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Ready For Test Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  9.1.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 11 Oct 2023 05:35:36 PM UTC, comment #6: 

That might be a weak argument. But sometimes I find these "keywords" helpful when scanning through a range of commits (to try and "visually bisect" quickly). E.g., if something in the interpreter failed, it's likely not one of the commits that start with "doc:" or "gui:".
On the other hand, if something changed only when using the vm evaluator, it's more likely that one of the commits starting with "vm:" is the one to inspect.
If "configure" breaks or gives incorrect results, it's likely one of the commits starting with "build:" that might have caused it.
That's assuming that the commits are categorized "correctly".

"libgui" is a separate library. So, categorizing changes for it is pretty clear cut (and maybe could also be filtered by path). For other parts, that might be less obvious.

There might also be developers that have their main focus on only parts of Octave's code base. For those, these keywords could also be useful.
If you prefer to not use these keywords, or use a different set of keywords that's fine with me.

What do you have in mind?


Markus Mützel <mmuetzel>
Group administrator
Tue 10 Oct 2023 05:12:01 AM UTC, comment #5: 

Initially, we just used "maint" to indicate that the commit wasn't really a change in Octave code but something like a merge commit, changes in whitespace, spell checking, etc.  I don't know that it is useful for us to add a prefix to categorize all other changes.  What makes "vm", "gui", and "build" special such that they need to be tagged separately from other changes?

John W. Eaton <jwe>
Group administrator
Mon 09 Oct 2023 09:11:42 PM UTC, comment #4: 


comment #2:

> We are using a couple of "keywords" to indicate what a commit is about, e.g., "build", "maint", or "gui". These "keywords" are terminated by a colon ":". Please consider using a similar pattern in your commit messages. E.g.: "VM: Change something (bug #56789)."
>


Sure can do =)

Petter <petter>
Sun 08 Oct 2023 11:20:41 AM UTC, comment #3: 

I followed up with a patch to make sure `SIZE_MAX` is defined before it is used:
https://hg.savannah.gnu.org/hgweb/octave/rev/f58397ac2013

Markus Mützel <mmuetzel>
Group administrator
Sun 08 Oct 2023 08:26:04 AM UTC, comment #2: 

Thank you very much for your invaluable work on the VM. That is greatly appreciated! 👍

Just some organizational remarks:
Please include the bug number at the end of the first line of the commit message, e.g., "Add a fancy feature (bug #12345)."
That will make it easier to find potential context or the place to report issues with a change.
That could be done by the creator of the patch or the developer that is pushing it to the repository.

We are using a couple of "keywords" to indicate what a commit is about, e.g., "build", "maint", or "gui". These "keywords" are terminated by a colon ":". Please consider using a similar pattern in your commit messages. E.g.: "VM: Change something (bug #56789)."

Markus Mützel <mmuetzel>
Group administrator
Sun 08 Oct 2023 12:27:31 AM UTC, comment #1: 

Pushed. Marking as ready for test.

Arun Giridhar <arungiridhar>
Group Member
Sat 07 Oct 2023 09:00:12 PM UTC, original submission:  

I made three quite small patches.

octave_32367.patch:
    Makes Octave buildable on Debian 12 32bit.
    time_t* used where the called function expects *long.

octave_32368.patch:
    Fixes some sloppy pointer arithmetic that makes the VM crash.

octave_32369.patch:
    Fixes a GCC compiler warning that triggers on 32 bit systems.

Test suite runs fine with and without the VM. I get 4 fails that seems to be small precision errors on ode15i, sind, ode15s with and without the VM.

"Abs err 1.7764e-15 exceeds tol 1.1102e-15 by 7e-16"

Petter <petter>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #55214:  octave_32367.patch added by petter (903B - text/plain)
file #55215:  octave_32369.patch added by petter (1KiB - text/plain)
file #55216:  octave_32368.patch added by petter (7KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by arungiridhar (Posted a comment)
  • -email is unavailable- added by petter (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-10-08 arungiridhar StatusNone Ready For Test
        Planned ReleaseNone 9.1.0
    2023-10-07 petter Attached File- Added octave_32367.patch, #55214
        Attached File- Added octave_32369.patch, #55215
        Attached File- Added octave_32368.patch, #55216

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code