bugGNU Octave - Bugs: bug #64609, Package installs fail if include...

 
 

bug #64609: Package installs fail if include paths have spaces

Submitter:  John Donoghue <lostbard>
Submitted:  Wed 30 Aug 2023 12:19:21 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  lostbard Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
Fixed Release:  9.1.0 (current default) Planned Release:  9.1.0 (current default)
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 21 Sep 2023 07:41:28 PM UTC, comment #3: 

No further problems reported. Closing as fixed.

Arun Giridhar <arungiridhar>
Group Member
Wed 30 Aug 2023 02:48:27 PM UTC, comment #2: 

Looks good to me.
It might be more complicated to avoid possible issues with nested quotes more generally. But this is probably better in the large majority of cases than what we currently do.

I pushed your patch with minor changes to the default branch:
https://hg.savannah.gnu.org/hgweb/octave/rev/265930c2158b

If issues for some corner cases should arise, we can still deal with them then imho.

Marking as ready for test.

Markus M├╝tzel <mmuetzel>
Group Member
Wed 30 Aug 2023 12:21:36 AM UTC, comment #1: 

This patch fixes the issue for me

(file #55096)

John Donoghue <lostbard>
Group Member
Wed 30 Aug 2023 12:19:21 AM UTC, original submission:  

Related to #62090

If the include paths or libraries contain spaces, mkoctfile does not escape or quote them.

Using the io package as an example since it just contains a basic Makefile:


    octave 3> pkg install -verbose -forge io
    mkdir (C:\Users\johnd\AppData\Local\Temp\oct-upWcic)
    untar (C:\Users\johnd\AppData\Local\Temp\io-2.6.4-8xuyXe.tar.gz, C:\Users\johnd\AppData\Local\Temp\oct-upWcic)
    make: Entering directory '/tmp/oct-upWcic/io-2.6.4/src'
    C:/Users/johnd/AppData/Local/Programs/GNU\ Octave/Octave-9.0.0/mingw64/bin/mkoctfile-9.0.0.exe --verbose csvexplode.cc
    g++ -c -IC:\Users\johnd\AppData\Local\Programs\GNU Octave\Octave-9.0.0\mingw64/include  -I"C:\Users\johnd\AppData\Local\Programs\GNU Octave\Octave-9.0.0\mingw64\include\octave-9.0.0\octave\.." -I"C:\Users\johnd\AppData\Local\Programs\GNU Octave\Octave-9.0.0\mingw64\include\octave-9.0.0\octave" -I"C:\Users\johnd\AppData\Local\Programs\GNU Octave\Octave-9.0.0\mingw64\include"  -pthread -fopenmp -g -O2    csvexplode.cc -o C:\Users\johnd\AppData\Local\Temp/oct-MjCRUd.o
    g++: warning: Octave\Octave-9.0.0\mingw64/include: linker input file unused because linking not done
    g++: error: Octave\Octave-9.0.0\mingw64/include: linker input file not found: No such file or directory
    make: *** [Makefile:6: csvexplode.oct] Error 1
    make: Leaving directory '/tmp/oct-upWcic/io-2.6.4/src'
    error: pkg: error running 'make' for the io package
    error: called from
        configure_make at line 117 column 9
        install at line 202 column 7
        pkg at line 619 column 9
    octave:4>


If the function that replaces the prefix value adds quotes for the replaces prefix if it has spaces, then the io package installs ok

John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #55096:  bug64609.patch added by lostbard (1009B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by arungiridhar (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-09-21 arungiridhar StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2023-08-30 mmuetzel StatusNone Ready For Test
        Fixed ReleaseNone 9.1.0 (current default)
        Planned ReleaseNone 9.1.0 (current default)
    2023-08-30 lostbard Attached File- Added bug64609.patch, #55096

    Back to the top

    Powered by Savane 3.12