bugGNU Octave - Bugs: bug #64599, Inconsistent warning ID for future...

 
 

bug #64599: Inconsistent warning ID for future time stamp check in liboctave

Submitter:  Linton Miller <linton>
Submitted:  Fri 25 Aug 2023 10:14:37 PM UTC
   
 
Category:  Coding Style and Maintenance Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Linton Miller Open/Closed:  * Closed
Release:  * stable Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 21 Sep 2023 07:40:34 PM UTC, comment #2: 

No further problems reported. Closing as fixed.

Arun Giridhar <arungiridhar>
Group Member
Sat 26 Aug 2023 07:12:58 AM UTC, comment #1: 

Thank you for your contribution. I pushed it with some minor additional changes here:
https://hg.savannah.gnu.org/hgweb/octave/rev/66d977e17588

Since "time stamp" is written with two words in the warning id, I also chose to write it with two words in the warning string. I also changed the preposition to match the other warning string.

I'm undecided on which branch this should go. If other maintainers think it should better go there, please don't hesitate to graft to the stable branch.

Marking as ready for test.

Markus M├╝tzel <mmuetzel>
Group Member
Fri 25 Aug 2023 10:14:37 PM UTC, original submission:  

There is a very minor inconsistency in the ID used for the "time stamp on file X is in the future" warning between the interpreter and dynamic library functions.

libinterp/parse-tree/oct-parse.yy

  warning_with_id ("Octave:future-time-stamp",
                   "time stamp for '%s' is in the future", nm.c_str ())


liboctave/util/oct-shlib.cc

    (*current_liboctave_warning_with_id_handler)
      ("Octave:warn-future-time-stamp",
       "timestamp on file %s is in the future", m_file.c_str ());


These are the same check, just done in different contexts, so my expectation is they should both use the same warning ID. Given the standard naming scheme, that would be Octave:future-time-stamp.

Thus the fix would be to change oct-shlib.cc to use that. I will attach a patch doing so.

Linton Miller <linton>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #55080:  bug64599.patch added by linton (821B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by arungiridhar (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by linton (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-09-21 arungiridhar StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2023-08-26 mmuetzel StatusNone Ready For Test
    2023-08-25 linton Attached File- Added bug64599.patch, #55080

    Back to the top

    Powered by Savane 3.12