bugGNU Octave - Bugs: bug #63483, [octave forge] (ncarray) BISTs...

 
 

bug #63483: [octave forge] (ncarray) BISTs fail against statistics 1.5.1

Submitter:  Sébastien Villemot <svillemot>
Submitted:  Wed 07 Dec 2022 04:55:12 PM UTC
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Fri 16 Dec 2022 05:47:01 PM UTC, comment #5: 

i pushed up a change to ncarray to fallover to use mean and var with the 'omitnan' option when it cant find nanmean and nanvar so it should work with older statistics as well as 1.5.2

John Donoghue <lostbard>
Project Member
Fri 16 Dec 2022 03:02:46 PM UTC, comment #4: 

var and std functions in statistics 1.5.2 allow for the 'omitnan' option. Please, use these instead of nanvar and nanstd, which were removed. As previously mentioned, if required they will be reinstated in the forthcoming release at the end of January so they can properly work with the updated functions.

There is an ongoing effort to include these functions with the 'omitnan' flag (among other options) into core Octave 8, so it would be best to start migrating your code to use these updated functions.

Andreas Bertsatos <pr0m1th3as>
Fri 16 Dec 2022 01:22:13 PM UTC, comment #3: 

If i use mean with omitnan option, it then fails with no nanvar function.

John Donoghue <lostbard>
Project Member
Wed 07 Dec 2022 06:05:36 PM UTC, comment #2: 

The nanmean function has been removed due to the recent mean implementation which can handle nanflag option. I am in the process of re-implementing these stats functions to be able to handle nanflag along with other MATLAB compatible options such as 'vecdim' and 'all'. Users can use "omitnan" option in mean, instead of the nanmean function, which cannot handle all other options such as vecdim.

If nanmean is necessary though, I could reinstate it in the forthcoming by the end of January, since it will require a significant overhaul including changes in the documentation and input argument checking so it can work properly with the new mean function. I assume I could do this for all other relevant functions (var, std, median) that I am in the process of updating to include the functionality introduced lately in MATLAB.

If time permits, I will re-implement functions nanmin, nanmax, nansum, nanprod

Andreas Bertsatos <pr0m1th3as>
Wed 07 Dec 2022 05:17:06 PM UTC, comment #1: 

CC-ing pr0m1th3as: Would you consider deprecating those functions for some time before removing them? (In Octave core, we usually deprecate functions for about two years, i.e., two major versions.)

Markus Mützel <mmuetzel>
Project Member
Wed 07 Dec 2022 04:55:12 PM UTC, original submission:  

Hi,

The nanmean function has been removed from the statistics package in version 1.5.1.

As a consequence, the BISTs of ncarray now fail:

[inst/test_ncarray_nan.m]
>>>>> /tmp/autopkgtest-lxc.ltybdnab/downtmp/build.ph8/src/inst/test_ncarray_nan.m
***** test
 test_ncarray_nan ()
!!!!! test failed
'nanmean' undefined near line 42, column 14

The 'nanmean' function belongs to the statistics package from Octave
Forge but has not yet been implemented.

Please read <https://www.octave.org/missing.html> to learn how you can
contribute missing functionality.
warning: test: file /tmp/autopkgtest-lxc.ltybdnab/downtmp/build.ph8/src/inst/test_ncarray_nan.m leaked global variables: CACHED_DECOMPRESS_DIR CACHED_DECOMPRESS_LOG_FID CACHED_DECOMPRESS_MAX_SIZE
1 test, 0 passed, 0 known failure, 0 skipped
[inst/test_ncarray.m]
>>>>> /tmp/autopkgtest-lxc.ltybdnab/downtmp/build.ph8/src/inst/test_ncarray.m
***** test
 test_ncarray()
!!!!! test failed
'nanmean' undefined near line 107, column 19

The 'nanmean' function belongs to the statistics package from Octave
Forge but has not yet been implemented.

Please read <https://www.octave.org/missing.html> to learn how you can
contribute missing functionality.
1 test, 0 passed, 0 known failure, 0 skipped

Sébastien Villemot <svillemot>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by pr0m1th3as (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by svillemot (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-12-07 mmuetzel Carbon-Copy- Added pr0m1th3as

    Back to the top

    Powered by Savane 3.10