bugGNU Octave - Bugs: bug #62750, Missing <ctime> include in...

 
 

bug #62750: Missing <ctime> include in liboctave/numeric/randmtzig.cc

Submitter:  Stefan Brüns <stefanbruens>
Submitted:  Mon 11 Jul 2022 08:59:50 PM UTC
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 7.1.0 Operating System:  * Any
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Thu 14 Jul 2022 11:10:26 AM UTC, comment #4: 

The CI did a complete cycle and passed afaict.
IIUC, the change fixed the issue for the OR.

Closing as fixed.

Markus Mützel <mmuetzel>
Project Member
Tue 12 Jul 2022 03:55:23 PM UTC, comment #3: 

Mercurial didn't like the Git patch. (I believe I saw something similar happening with a patch that also had an author with non-ASCII characters in their name.)

I made the changes manually and pushed them with you as the author here:
https://hg.savannah.gnu.org/hgweb/octave/rev/8245e773bb5b

Marking as ready for test.

Markus Mützel <mmuetzel>
Project Member
Tue 12 Jul 2022 06:50:35 AM UTC, comment #2: 

That might have been caused by removing that include from the `lib*-build-info.h` headers for bug #61821.

Depending on the used compiler or CRT (or something else) that header might happen to still be included implicitly in that file. But including it explicitly seems like the right thing to do.

Markus Mützel <mmuetzel>
Project Member
Mon 11 Jul 2022 09:09:36 PM UTC, comment #1: 

Fedora 36 has

gcc/libstdc++ 12.1.1

and there is not problem there commpiling octave.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Mon 11 Jul 2022 08:59:50 PM UTC, original submission:  

Building octave 7.1.0 fails:

[  675s] liboctave/numeric/randmtzig.cc: In function 'void octave::init_mersenne_twister()':
[  675s] liboctave/numeric/randmtzig.cc:274:22: error: 'clock' was not declared in this scope; did you mean 'clock_t'?
[  675s]   274 |       entropy[n++] = clock ();
[  675s]       |                      ^~~~~
[  675s]       |                      clock_t

This is due to some changes in the toolchain/libs (which I have to investigate), i.e. the required <ctime> is no longer included implicitly.

Likely candidate is the update of GCC/libstdc++ from 12.1.0 to 12.1.1.

Stefan Brüns <stefanbruens>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by stefanbruens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-07-14 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2022-07-12 mmuetzel StatusNone Ready For Test
        Operating SystemGNU/Linux Any
    2022-07-12 mmuetzel Item GroupNone Build Failure
    2022-07-11 stefanbruens Attached File- Added 0001-Add-explicit-ctime-include-required-for-clock.patch, #53418

    Back to the top


    Powered by Savane 3.9