bugGNU Octave - Bugs: bug #62106, GUI fails to build for Qt <...

 
 

bug #62106: GUI fails to build for Qt < 5.11

Submitter:  Rik <rik5>
Submitted:  Wed 23 Feb 2022 09:02:16 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  ttl
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 04 Mar 2022 05:21:47 PM UTC, comment #4: 

Thanks.
Switching the icon sets works for me on Ubuntu 21.10. And the Ubuntu 18.04 runners with Qt 5.9.5 also compile without issues.

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Thu 24 Feb 2022 09:36:11 PM UTC, comment #3: 

I have pushed cset http://hg.savannah.gnu.org/hgweb/octave/rev/439eb9bd4c04 which re-implements a fallback mechanism for icons, that are possibly missing in the currently selected icon theme, without using QIcon::setFallbackSearchPaths.

Torsten Lilge <ttl>
Group Member
Thu 24 Feb 2022 01:06:55 AM UTC, comment #2: 

@Torsten: Thanks for the quick patch.  I can at least build now.

Rik <rik5>
Group administrator
Wed 23 Feb 2022 10:30:23 PM UTC, comment #1: 

That was the reason why I was asking on discourse for a minimal version of qt5 we can expect. For now, I have added a quick test for the qt version. This will lead to some missing icons with qt version less than 5.11. But I will look for a workaround within the next couple of days.

Torsten Lilge <ttl>
Group Member
Wed 23 Feb 2022 09:02:16 PM UTC, original submission:  

Trying to build the development branch today (February 23, 2022) I get the following errors


libgui/src/resource-manager.cc: In member function ‘void octave::resource_manager::config_icon_theme()’:
libgui/src/resource-manager.cc:190:35: error: ‘fallbackSearchPaths’ is not a member of ‘QIcon’
     QStringList fallbacks (QIcon::fallbackSearchPaths ());
                                   ^~~~~~~~~~~~~~~~~~~
libgui/src/resource-manager.cc:209:12: error: ‘setFallbackSearchPaths’ is not a member of ‘QIcon’
     QIcon::setFallbackSearchPaths (fallbacks);
            ^~~~~~~~~~~~~~~~~~~~~~


According to Qt documentation these two functions were introduced in Qt 5.11.  I am using Kubuntu 18.04 which is a long-term release and comes with Qt 5.9.5.  I expect there are a lot of other users with older Qt versions.

Seems like it would be worth adding a configuration test in configure.ac or acinclude.m4 and providing a workaround for older libraries.

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-03-04 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2022-02-24 ttl StatusIn Progress Ready For Test
    2022-02-23 ttl StatusConfirmed In Progress
        Assigned toNone ttl

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code