bugGNU Octave - Bugs: bug #61826, [octave forge] (fl-core) : should...

 
 

bug #61826: [octave forge] (fl-core) : should provide an up-to-date tarball/release

Submitted by:  Stefan Brüns <stefanbruens>
Submitted on:  Fri 14 Jan 2022 06:03:14 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  other Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Wed 19 Jan 2022 06:19:03 PM UTC, comment #8: 

OK, I made it 4.4

Nir Krakauer <nir_krakauer>
Wed 19 Jan 2022 05:27:50 PM UTC, comment #7: 

I see feval in the octave namespace in parse.h in 4.4, but doesnt look to be in 4.2 ?

John Donoghue <lostbard>
Project Member
Wed 19 Jan 2022 04:48:22 PM UTC, comment #6: 

Thanks, I committed your Makefile at https://sourceforge.net/p/octave/fl-core/ci/8a1edb52e334db91920da05f24cdfba77ff21609/

What would the new minimum Octave version be?

Nir Krakauer <nir_krakauer>
Wed 19 Jan 2022 04:00:22 PM UTC, comment #5: 

Stealing the makefile I use for octave-ga appears to work (attached)

(file #52681)

John Donoghue <lostbard>
Project Member
Wed 19 Jan 2022 03:53:34 PM UTC, comment #4: 

The makefile is easy - I can provide that - the tests not so much.

I can remeber when  octave::feval etc became available in octave - but the DESCRIPTION file would need to update (if it isnt) to a version that provided that.

John Donoghue <lostbard>
Project Member
Wed 19 Jan 2022 02:57:37 PM UTC, comment #3: 

I pushed Pantxo's fixes to the repo:
https://sourceforge.net/p/octave/fl-core/ci/b65682c396bf1bb2041e1203c6ba39cf144750b5/

Beyond that, making a new release is not straightforward, as there isn't a package Make file (as we've had in maintained packages since around 2016), and there are no tests to verify the performance of the package functions.

If someone can provide patches to address these problems, I'm willing to work with them to make a new release.

Nir Krakauer <nir_krakauer>
Mon 17 Jan 2022 01:10:26 PM UTC, comment #2: 

There is also fuzzy-logic-toolkit, which may be more up to date

John Donoghue <lostbard>
Project Member
Fri 14 Jan 2022 08:57:36 PM UTC, comment #1: 

Out of curiosity, I cloned fl-core repository and tried to build it against the current Octave 6 API:

$ hg clone http://hg.code.sf.net/p/octave/fl-core octave-fl-core
$ cd octave-fl-core/src
$ make

but that fails.

>> Just releasing the current state should not be too much work.

As you noted, the package is unmaintained: are you proposing yourself to do that work?
If so, or if it may help anyone, here are the changes I had to make to have the package just compile (completely untested):

diff -r 8e7292478faf src/fl_compose.cc
--- a/src/fl_compose.cc Wed Jul 06 11:09:56 2016 -0400
+++ b/src/fl_compose.cc Fri Jan 14 21:31:50 2022 +0100
@@ -185,7 +185,7 @@


        // Check if the matrices are both both sparse and set the output matrix to sparse type
-       if(args(0).is_sparse_type() && args(1).is_sparse_type())
+       if(args(0).issparse() && args(1).issparse())
                sparse_res = 1;


@@ -627,11 +627,15 @@
        octave_value_list testArgs;
        testArgs(0) = 1;
        testArgs(1) = 2;
-       feval(func,testArgs);
-       if(error_state)
-               return 0;
-       else
-               return 1;
+    try
+      {
+        octave::feval(func,testArgs);
+      }
+    catch (octave::execution_exception&)
+      {
+        return 0;
+      }
+    return 1;
 }


@@ -730,7 +734,7 @@
        octave_value_list fargs;
        fargs(0) = octave_value(first);
        fargs(1) = octave_value(second);
-       return feval(tnorm,fargs)(0).float_value();
+       return octave::feval(tnorm,fargs)(0).float_value();
 }


@@ -741,7 +745,7 @@
        octave_value_list fargs;
        fargs(0) = octave_value(first);
        fargs(1) = octave_value(second);
-       return feval(snorm,fargs)(0).float_value();
+       return octave::feval(snorm,fargs)(0).float_value();
 }

Pantxo Diribarne <pantxo>
Project Member
Fri 14 Jan 2022 06:03:14 PM UTC, original submission:  

Although fl-core is in state unmaintained, the current repository is significantly more recent and contains several bug fixes.

Just releasing the current state should not be too much work.

Unfortunately, SF makes it impossible to download patches from the website.

Stefan Brüns <stefanbruens>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52681:  Makefile added by lostbard (9KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by stefanbruens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-19 lostbard Attached File- => Added Makefile, #52681
    2022-01-14 pantxo Summaryfl-core should provide an up-to-date tarball/release => [octave forge] (fl-core) : should provide an up-to-date tarball/release

    Back to the top


    Powered by Savane 3.7