bugGNU Octave - Bugs: bug #61767, pinv: more consistent error...

 
 

bug #61767: pinv: more consistent error messaging

Submitter:  A.R. Burgers <arb>
Submitted:  Thu 06 Jan 2022 09:57:05 AM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Missed Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 07 Jan 2022 09:29:23 PM UTC, comment #1: 

Yes, this was a sensible change after tightening the input validation for inv().  I checked in your change here (http://hg.savannah.gnu.org/hgweb/octave/rev/09012191bb0c) after making a few changes to conform to Octave coding standards such as using a space between the function name and opening parenthesis.

Thanks for the changeset.  Marking as Fixed and closing report.

Rik <rik5>
Group administrator
Thu 06 Jan 2022 09:57:05 AM UTC, original submission:  

make input validation in pinv analogous to that in inv as in bug #61728. Exit early when the input is neither numeric nor bool, but allowing int/uint integral types. See the attached changeset.

add a few additional tests for inv input validation as well.

A.R. Burgers <arb>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52619:  pinv_input_validation.patch added by arb (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by arb (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-07 rik5 StatusNone Fixed
        Open/ClosedOpen Closed
    2022-01-06 arb Attached File- Added pinv_input_validation.patch, #52619

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code