bugGNU Octave - Bugs: bug #61578, [octave forge] (strings) Remove...

 
 

bug #61578: [octave forge] (strings) Remove usage of "error_state"

Submitted by:  Markus Mützel <mmuetzel>
Submitted on:  Sun 28 Nov 2021 09:11:01 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Patch Reviewed Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Thu 20 Jan 2022 08:23:29 PM UTC, comment #6: 

Until a new release is made - yes

John Donoghue <lostbard>
Project Member
Thu 20 Jan 2022 04:07:41 PM UTC, comment #5: 

As of today I am getting the following two errors on trying to install this package. Is this expected for now?

octave:3> pkg install -forge strings
error: 'octave_config_info' undefined near line 1, column 7
pcregexp.cc:51:9: error: use of undeclared identifier 'error_state'
    if (error_state) {
        ^
pcregexp.cc:52:9: error: use of undeclared identifier 'gripe_wrong_type_arg'; did you mean 'err_wrong_type_arg'?
        gripe_wrong_type_arg("pcregexp", args(0));
        ^~~~~~~~~~~~~~~~~~~~
        err_wrong_type_arg
/usr/local/include/octave-8.0.0/octave/errwarn.h:119:1: note: 'err_wrong_type_arg' declared here
err_wrong_type_arg (const char *name, const octave_value& tc);
^
2 errors generated.
make: *** [Makefile:11: pcregexp.oct] Error 1

Arun Giridhar <arungiridhar>
Mon 10 Jan 2022 09:47:29 PM UTC, comment #4: 

toascii issue was reported in #59341

John Donoghue <lostbard>
Project Member
Mon 10 Jan 2022 08:40:00 PM UTC, comment #3: 

With 7.0.90 rc1 on Windows:


pkg test strings
<...>
Failure Summary:

  ..90\mingw64\share\octave\packages\strings-1.2.0\base64decode.m  pass    0/6
                                                                   FAIL    6
  ..90\mingw64\share\octave\packages\strings-1.2.0\base64encode.m  pass    0/2
                                                                   FAIL    2

Summary:

  PASS                               18
  FAIL                                8

<...>

>> test base64decode
***** assert(base64decode(base64encode('Hakuna Matata'),true),'Hakuna Matata')
!!!!! test failed
'toascii' undefined near line 49, column 9

>> test base64encode
***** assert (base64encode ('Hakuna Matata', true), 'SGFrdW5hIE1hdGF0YQ==')
!!!!! test failed
'toascii' undefined near line 49, column 9

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Thu 02 Dec 2021 01:47:40 PM UTC, comment #2: 

I added the change to the strings repo - not sure if Oliver is still maintaining the package, or is good with someone else creating a new release.

John Donoghue <lostbard>
Project Member
Sun 28 Nov 2021 09:12:20 PM UTC, comment #1: 

Attaching possible patch.

(file #52369)

Markus Mützel <mmuetzel>
Project Member
Sun 28 Nov 2021 09:11:01 PM UTC, original submission:  

Quoting jwe from bug #61551:

> The global 'error_state' variable has been useless for quite some time now.  It's been removed on the default branch (what will become version 8.1 in about a year).  Since about 6 years ago, it has never had a value other than 0 in Octave code and is no longer useful for checking whether an error has occurred because exceptions are thrown, so checking the state of a variable after an error occurs is not useful except inside a 'catch' clause that handles 'octave::execution_exception'.
> All uses of this variable should be removed from the video package and any other packages that still use it.  You should have been seeing a warning at compile time about it being deprecated since before version 6 was released (it was marked as deprecated in May 2019).


This also applies to the strings package.
I'll attach a possible patch as soon as I'll have a bug number.

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52369:  of-strings-2-error_state.patch added by mmuetzel (869B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by arungiridhar (Posted a comment)
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by mmuetzel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-12-02 lostbard StatusPatch Submitted => Patch Reviewed
    2021-11-28 mmuetzel Attached File- => Added of-strings-2-error_state.patch, #52369
        StatusNone => Patch Submitted
        Carbon-Copy- => Added oheim

    Back to the top


    Powered by Savane 3.7