bugGNU Octave - Bugs: bug #61568, [octave forge] (interval) Fix...

 
 

bug #61568: [octave forge] (interval) Fix compilation with Octave 8

Submitted by:  Markus Mützel <mmuetzel>
Submitted on:  Fri 26 Nov 2021 05:05:38 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Patch Submitted Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 10 Jan 2022 11:26:13 PM UTC, comment #2: 

The patch has been applied in the repository, thank you very much for the preparation.

According to [1] the error_state has been replaced by the exception mechanism in 2016 with Octave 4.2.  Thus, the minimum Octave version of the package should probably be increased from 3.8 to 4.2.

Or am I missing something?

[1] https://www.gnu.org/software/octave/NEWS-4.2.html

Oliver Heimlich <oheim>
Fri 26 Nov 2021 05:07:32 PM UTC, comment #1: 

A possible patch is attached.

(file #52352)

Markus Mützel <mmuetzel>
Project Member
Fri 26 Nov 2021 05:05:38 PM UTC, original submission:  

Quoting jwe from bug #61551:

> The global 'error_state' variable has been useless for quite some time now.  It's been removed on the default branch (what will become version 8.1 in about a year).  Since about 6 years ago, it has never had a value other than 0 in Octave code and is no longer useful for checking whether an error has occurred because exceptions are thrown, so checking the state of a variable after an error occurs is not useful except inside a 'catch' clause that handles 'octave::execution_exception'.
> All uses of this variable should be removed from the video package and any other packages that still use it.  You should have been seeing a warning at compile time about it being deprecated since before version 6 was released (it was marked as deprecated in May 2019).


This also applies to the interval package.
I'll attach a possible patch as soon as I'll have a bug number.

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52352:  of-interval-3-error_state.patch added by mmuetzel (6KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by oheim (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  • -email is unavailable- added by mmuetzel
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-26 mmuetzel Attached File- => Added of-interval-3-error_state.patch, #52352
        StatusNone => Patch Submitted
    2021-11-26 mmuetzel Carbon-Copy- => Added oheim

    Back to the top


    Powered by Savane 3.7