bugGNU Octave - Bugs: bug #61564, [octave forge] (signal) Fix...

 
 

bug #61564: [octave forge] (signal) Fix compilation with Octave 8

Submitter:  Markus Mützel <mmuetzel>
Submitted:  Fri 26 Nov 2021 03:58:47 PM UTC
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  lostbard
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Sun 24 Apr 2022 11:02:52 AM UTC, comment #3: 

Closing as fixed with the new release of signal 1.4.2

John Donoghue <lostbard>
Project Member
Thu 21 Apr 2022 09:32:58 PM UTC, comment #2: 
John Donoghue <lostbard>
Project Member
Fri 26 Nov 2021 04:01:10 PM UTC, comment #1: 

A possible patch is attached.

(file #52348)

Markus Mützel <mmuetzel>
Project Member
Fri 26 Nov 2021 03:58:47 PM UTC, original submission:  

Quoting jwe from bug #61551:

> The global 'error_state' variable has been useless for quite some time now.  It's been removed on the default branch (what will become version 8.1 in about a year).  Since about 6 years ago, it has never had a value other than 0 in Octave code and is no longer useful for checking whether an error has occurred because exceptions are thrown, so checking the state of a variable after an error occurs is not useful except inside a 'catch' clause that handles 'octave::execution_exception'.
> All uses of this variable should be removed from the video package and any other packages that still use it.  You should have been seeing a warning at compile time about it being deprecated since before version 6 was released (it was marked as deprecated in May 2019).


This is also applies to the signal package.

I'll attach a possible patch as soon as I'll have a bug number.

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52348:  of-signal-2-error_state.patch added by mmuetzel (4KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  • -email is unavailable- added by mmuetzel
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-04-24 lostbard StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2022-04-21 lostbard StatusPatch Submitted Ready For Test
        Assigned toNone lostbard
    2021-11-26 mmuetzel Attached File- Added of-signal-2-error_state.patch, #52348
        StatusNone Patch Submitted
    2021-11-26 mmuetzel Carbon-Copy- Added mtmiller

    Back to the top


    Powered by Savane 3.9