bugGNU Octave - Bugs: bug #61470, JupyterNotebook should not...

 
 

bug #61470: JupyterNotebook should not hardwire a temporary directory name

Submitter:  John W. Eaton <jwe>
Submitted:  Fri 12 Nov 2021 04:14:38 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  jwe Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 22 Nov 2021 04:32:17 PM UTC, comment #5: 

Thanks for checking @arungiridhar.

If the probably false positives of the AddressSanitizer are worth further investigation, this report can be reopened any time.

Closing as fixed.

Kai Torben Ohlhus <siko1056>
Group Member
Mon 15 Nov 2021 05:32:31 PM UTC, comment #4: 

Apologies! I didn't realize the change wasn't pushed already. I now tried 488548c762de. The "existing directory" error does not arise any more. Thank you, jwe, for the patch and to Kai for pointing me to the correct direction.

In a debug build with AddressSanitizer, there are still repeatable crashes with jupyter-notebook/jupyter-notebook.tst because of memory leaks (could be false positives), but subsequent runs all behave consistently without giving a directory error. That output is attached.

The regular build (without AddressSanitizer) passes all BISTs except for the known ones.

(file #52281)

Arun Giridhar <arungiridhar>
Group Member
Mon 15 Nov 2021 09:13:18 AM UTC, comment #3: 

@arungiridhar (comment #2): jwe did not push the patch yet, thus

https://hg.savannah.gnu.org/hgweb/octave/rev/6c7567bfac91

did not contain the fix for the problem.

Can you check if it is working with the latest Octave version from the repository?

@jwe: Thank you for the changes.  All looks great and pushed them with completed constructor and documentation:

https://hg.savannah.gnu.org/hgweb/octave/rev/488548c762de

Kai Torben Ohlhus <siko1056>
Group Member
Sat 13 Nov 2021 11:03:24 AM UTC, comment #2: 

This error persists in 6c7567bfac91 and is repeatable when building with AddressSanitizer for debugging.

The first time that "make check" is run, it crashes at jupyter-notebook/JupyterNotebook.tst because AddressSanitizer detects a buffer overflow, which may be a false positive. (Output attached as file jupyter_crash)

The second time that "make check" is run, it does not crash at jupyter-notebook/JupyterNotebook.tst but fails all those tests with this log output:


  jupyter-notebook/JupyterNotebook.tst ........................... pass    0/4
                                                                   FAIL    4
>>>>> processing octave/test/jupyter-notebook/JupyterNotebook.tst

!!!!! test failed
JupyterNotebook: temporary directory __octave_jupyter_temp__ exists.  Please remove it manually.

!!!!! test failed
JupyterNotebook: temporary directory __octave_jupyter_temp__ exists.  Please remove it manually.

!!!!! test failed
JupyterNotebook: temporary directory __octave_jupyter_temp__ exists.  Please remove it manually.

!!!!! test failed
JupyterNotebook: temporary directory __octave_jupyter_temp__ exists.  Please remove it manually.


Removing that directory and rerunning "make check" brings back the AddressSanitizer crash.

(file #52266)

Arun Giridhar <arungiridhar>
Group Member
Fri 12 Nov 2021 04:28:55 PM UTC, comment #1: 

Changeset with possible fix attached.

(file #52261)

John W. Eaton <jwe>
Group administrator
Fri 12 Nov 2021 04:14:38 PM UTC, original submission:  

I started seeing test failures with JupyterNotebook.tst that were happening because the temporary directory it uses had not been deleted in a previous run of the tests. Then I noticed that it uses a fixed name for its temporary directory.

I'll attach a patch when I have a bug number.

John W. Eaton <jwe>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52281:  jupyter2 added by arungiridhar (6KiB - application/octet-stream)
file #52266:  jupyter_crash added by arungiridhar (6KiB - application/octet-stream)
file #52261:  jupyter-notebook-patch.txt added by jwe (4KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by siko1056 (Author)
  • -email is unavailable- added by arungiridhar (Updated the item)
  • -email is unavailable- added by jwe (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-22 siko1056 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2021-11-15 arungiridhar Attached File- Added jupyter2, #52281
    2021-11-15 siko1056 StatusPatch Submitted Ready For Test
        Carbon-Copy- Added -email is unavailable-
    2021-11-13 arungiridhar Attached File- Added jupyter_crash, #52266
    2021-11-12 jwe Attached File- Added jupyter-notebook-patch.txt, #52261
        StatusNone Patch Submitted

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code