bugGNU Octave - Bugs: bug #61396, octave wrapper executable not...

 
 

bug #61396: octave wrapper executable not working properly on Windows

Submitter:  Markus Mützel <mmuetzel>
Submitted:  Thu 28 Oct 2021 06:01:53 PM UTC
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Sat 30 Oct 2021 08:20:05 PM UTC, comment #2: 

Seems to be working for me now.

Closing as fixed.

Markus Mützel <mmuetzel>
Project Member
Thu 28 Oct 2021 06:07:01 PM UTC, comment #1: 

I pushed that change to the default branch here:
http://hg.savannah.gnu.org/hgweb/octave/rev/e1b0ed07895b

Marking as ready for test.

Markus Mützel <mmuetzel>
Project Member
Thu 28 Oct 2021 06:01:53 PM UTC, original submission:  

As discussed during last online maintainers meeting, the `octave` wrapper executable doesn't work correctly on Windows.
The way a terminal waits for a child process on that platform basically makes it impossible to mimick the behavior of `exec` or `spawn` with `P_OVERLAY` on POSIX.

See also: https://wiki.octave.org/Online_Developer_Meeting_(2021-10-26)#spawn_with_P_OVERLAY_works_differently_on_POSIX_and_Windows

An idea was to get rid of the wrapper executable short term on that platform and replacing it by `octave-gui`. However, looking into it in a bit more detail, that makes building Octave on that platform awkward as long as we still need that wrapper executable on POSIX platforms.
Instead, I opted for implementing `octave_execv_wrapper` on that platform with `spawn` and `P_WAIT`. That makes the behavior the user observes when calling the wrapper executable very similar to the one on POSIX platforms. At the same time, the build system can stay untouched.

I'm mainly opening this report to explain why I chose to use a different implementation than the one we talked about. I figured that would be better here than in a lengthy commit message.

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-10-30 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2021-10-28 mmuetzel StatusNone Ready For Test

    Back to the top


    Powered by Savane 3.9