bugGNU Octave - Bugs: bug #60629, UPSTREAM: classdef methods access...

 
 

bug #60629: UPSTREAM: classdef methods access attribute: colorize keyword Access

Submitted by:  PIERRE LABRECHE <pierre5018>
Submitted on:  Tue 18 May 2021 02:25:56 PM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Confirmed Assigned to:  None
Originator Name:  PIERRE LABRECHE Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 26 May 2021 03:12:49 PM UTC, comment #4: 

Attributes are part of the language; thus, in my opinion, deserve highlighting.

For example, if syntax highlighting covered attributes, users could see right away that the attribute "Constant" for properties, when written in lowercase, i.e. "constant", is not recognized.

For attributes, perhaps a specific color could be used.

PIERRE LABRECHE <pierre5018>
Wed 26 May 2021 02:47:55 PM UTC, comment #3: 

If this is an opinion question, do you want to raise the issue on the Octave Discourse site in the Maintainer's section?  Specifically, the question seems to be "Should Octave colorize attributes, or only keywords?".

Personally, I don't have an opinion and in any case use Vim for editing rather than the built-in editor.

Rik <rik5>
Project Administrator
Wed 26 May 2021 12:02:35 PM UTC, comment #2: 

Before opening a ticket upstream I have done some testing. "Static" is the only attribute that is highlighted. All other attributes - not only "Access" - are not highlighted (for methods or properties). In Matlab, attributes aren't highlighted either. So it looks like the bug is that "Static" is highlighted.

Personally, I think that highlighting a method or property attribute in the same way as a keyword does not feel correct.

Torsten Lilge <ttl>
Project Member
Fri 21 May 2021 10:40:51 PM UTC, comment #1: 

Syntax highlighting is done by Qscintilla.  This probably needs to be reported upstream.  See, for example, bug #59885.

Rik <rik5>
Project Administrator
Tue 18 May 2021 02:25:56 PM UTC, original submission:  

The classdef methods attribute "Access" is not colorized, unlike the attribute "Static", which is shown in blue.

PIERRE LABRECHE <pierre5018>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by rik5
  • -email is unavailable- added by pierre5018 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-05-25 rik5 StatusNone => Confirmed
        Release6.2.0 => dev
        Operating SystemMicrosoft Windows => Any
        Summaryclassdef methods access attribute: colorize keyword Access => UPSTREAM: classdef methods access attribute: colorize keyword Access
    2021-05-21 rik5 Carbon-Copy- => Added ttl

    Back to the top


    Powered by Savane 3.6