bugGNU Octave - Bugs: bug #60610, configure: missing RapidJSON does...

 
 

bug #60610: configure: missing RapidJSON does not emit a warning at configure time

Submitter:  Mike Miller <mtmiller>
Submitted:  Sat 15 May 2021 05:29:55 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Missed Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 17 May 2021 04:38:00 PM UTC, comment #9: 

Thanks, working in my test builds.

Mike Miller <mtmiller>
Group Member
Mon 17 May 2021 06:03:39 AM UTC, comment #8: 

I fixed a copy/paste error in the warning string here:
https://hg.savannah.gnu.org/hgweb/octave/rev/03d840d96b3a

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Sun 16 May 2021 09:30:27 PM UTC, comment #7: 

This seems fine to me.

Rik <rik5>
Group administrator
Sun 16 May 2021 08:21:53 PM UTC, comment #6: 

I made the changes you proposed and added links to the two bugs for which we apply patches in MXE Octave.
Pushed here:
https://hg.savannah.gnu.org/hgweb/octave/rev/490e400d4df0

Marking as ready for test

Markus Mützel <mmuetzel>
Group administrator
Sun 16 May 2021 05:43:22 PM UTC, comment #5: 

Maybe I'm overthinking, but it might also be useful to include a comment with an explanation and a link to the upstream issue https://github.com/Tencent/rapidjson/issues/1718 that has been fixed, but not yet released in the packaged version of RapidJSON for many distributions.

Mike Miller <mtmiller>
Group Member
Sun 16 May 2021 05:23:39 PM UTC, comment #4: 

Can you phrase the second warning to be something like

"RapidJSON library found, but some features..."

This is more consistent with other warning messages we have when a library is found but is too old or incompatible for some reason.

Other than that, patch looks great to me.

Mike Miller <mtmiller>
Group Member
Sun 16 May 2021 09:48:25 AM UTC, comment #3: 

The attached patch adds the warning when RapidJSON wasn't found during configure.
It also rephrases the warning slightly that is shown when the "PrettyWriter" option won't be available. IIUC, it isn't broken "per se" in most distributed versions of RapidJSON. It "just" doesn't compile with newer compilers. (IIUC, it would still work with gcc 7.)

(file #51442)

Markus Mützel <mmuetzel>
Group administrator
Sun 16 May 2021 05:36:25 AM UTC, comment #2: 

Thanks for pointing that out, I hadn't even looked at configure.ac yet or the history. For clarity, it would also be good to rename the warning message variable to "warn_rapidjson".

Mike Miller <mtmiller>
Group Member
Sun 16 May 2021 03:29:30 AM UTC, comment #1: 

The original warning has been removed in cset

https://hg.savannah.gnu.org/hgweb/octave/rev/699bba597610

Adding Rik to clarify if this was intentional.

Kai Torben Ohlhus <siko1056>
Group Member
Sat 15 May 2021 05:29:55 PM UTC, original submission:  

Typically the configure script warns when optional libraries aren't found that will lead to some feature being disabled or degraded in Octave. There is no warning for a missing RadidJSON library, so Octave can be built and the user won't know until run time that the JSON functions aren't functional.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #51442:  bug60610-rapidjson-conf-warn.patch added by mmuetzel (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by siko1056
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-05-17 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2021-05-16 mmuetzel StatusNeed Info Ready For Test
    2021-05-16 mmuetzel Attached File- Added bug60610-rapidjson-conf-warn.patch, #51442
        Operating SystemGNU/Linux Any
    2021-05-16 siko1056 StatusNone Need Info
    2021-05-16 siko1056 Carbon-Copy- Added rik5
    2021-05-15 mtmiller Carbon-CopyRemoved 80942 -

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code