bugGNU Octave - Bugs: bug #60601, AC_PROG_LEX without either yywrap...

 
 

bug #60601: AC_PROG_LEX without either yywrap or noyywrap is obsolete

Submitter:  Markus Mützel <mmuetzel>
Submitted:  Thu 13 May 2021 03:09:10 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 13 May 2021 05:26:19 PM UTC, comment #5: 

Works for me.
The warning has disappeared in the logs of the macOS runner.
And the remaining buildbot builders and GitHub runners seem to be happy with this change, too.

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Thu 13 May 2021 03:58:35 PM UTC, comment #4: 
John W. Eaton <jwe>
Group administrator
Thu 13 May 2021 03:51:34 PM UTC, comment #3: 

Yeah, I still have 2.69 as well and I wrote comment #1 before testing.  From reading the documentation, I just assumed that a call to AC_PROG_LEX with an argument would fail.  But that's not the behavior I'm seeing.  It appears to work anyway so I'll push a change.  I don't think we need the version test.

John W. Eaton <jwe>
Group administrator
Thu 13 May 2021 03:40:30 PM UTC, comment #2: 

I updated to Ubuntu 21.04 today. It still packages autoconf 2.69.
So we'd probably don't want to require autoconf 2.70 for a while.
I haven't tested that yet. But maybe we could use something similar to this instead?

m4_version_prereq([2.70],
  [AC_PROG_LEX(noyywrap)],
  [AC_PROG_LEX])


Markus Mützel <mmuetzel>
Group administrator
Thu 13 May 2021 03:29:54 PM UTC, comment #1: 

I started to apply this change


diff --git a/m4/acinclude.m4 b/m4/acinclude.m4
--- a/m4/acinclude.m4
+++ b/m4/acinclude.m4
@@ -3819,8 +3819,9 @@ AC_DEFUN([OCTAVE_PROG_FLEX], [
   ## it, and it might not be installed.
   ##
   ## Also make sure that we generate an interactive scanner if we are
-  ## using flex.
-  AC_PROG_LEX
+  ## using flex.  We declare %noyywrap in the lexer files so we use the
+  ## noyywrap option here to skip the search for that function.
+  AC_PROG_LEX(noyywrap)
   case "`$LEX --version`" in
     *flex*)
       LFLAGS="-I"


but then realized that it would force the build to require autoconf 2.70.  Is that something we want to do?

John W. Eaton <jwe>
Group administrator
Thu 13 May 2021 03:09:10 PM UTC, original submission:  

While running the bootstrap script on a GitHub-hosted macOS runner with autoconf 2.71, this warning is shown:

autoreconf: running: /usr/local/Cellar/autoconf/2.71/bin/autoconf --include=m4 --force
configure.ac:217: warning: AC_PROG_LEX without either yywrap or noyywrap is obsolete
./lib/autoconf/programs.m4:716: _AC_PROG_LEX is expanded from...
./lib/autoconf/programs.m4:709: AC_PROG_LEX is expanded from...
m4/acinclude.m4:3262: OCTAVE_PROG_FLEX is expanded from...
configure.ac:217: the top level


See also:
https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Particular-Programs.html#AC_PROG_LEX

Markus Mützel <mmuetzel>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-05-13 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2021-05-13 jwe StatusNone Ready For Test

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code