bugGNU Octave - Bugs: bug #60556, Editor fonts suddenly changed

 
 

bug #60556: Editor fonts suddenly changed

Submitter:  Lars Kindermann <larskindermann>
Submitted:  Sat 08 May 2021 10:25:29 AM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 27 May 2021 04:19:18 PM UTC, comment #13: 

I think the issue with the changing fonts is solved but Lars also mentioned some occasionally crashes when changing editor styles. Therefore, I am closing this bug report as fixed.

@Lars: If the crashes are still present on your system, please open a separate bug report for this.

Torsten Lilge <ttl>
Group Member
Thu 27 May 2021 03:09:01 PM UTC, comment #12: 

This report has been marked "Ready for Test" for ~3 weeks.  Is it okay to close?

Rik <rik5>
Group administrator
Sun 09 May 2021 12:51:17 PM UTC, comment #11: 

For me opening the settings file dialog takes the same time in dev and stable, too.

Opening the setting dialog might be slightly longer when you have not yet made some changes to the default editor styles. In this case the dialog gets all the default setting from qscintilla's lexers which might take longer compared to reading the setting from octave's settings file.

Torsten Lilge <ttl>
Group Member
Sun 09 May 2021 12:29:37 PM UTC, comment #10: 

Just compared with stable and 6.2.0, both opening and applying the Preferences dialog takes about three times longer in dev.

Lars Kindermann <larskindermann>
Sun 09 May 2021 12:18:17 PM UTC, comment #9: 

That's exactly what I do. Both from main and editor menu.

It is the build #0562777c015f on Debian 11 with Xfce desktop.

Lars Kindermann <larskindermann>
Sun 09 May 2021 11:24:47 AM UTC, comment #8: 

I don't see that poor performance with the preferences dialog.  To be clear, you mean using Edit -> Preferences from the main window menu bar, then selecting the "Editor" tab?  Each of those operations takes less than a second for me.  And opening the editor preferences from the editor tab menu bar is similar.

John W. Eaton <jwe>
Group administrator
Sun 09 May 2021 10:44:31 AM UTC, comment #7: 

Hard to reproduce, very intermittent problem.

I tried about 50 times to open and close the editor preferences and had two crashes. One after changing font size and pressing ok. Another one after the widget had closed and I clicked somewhere else in the gui.

It takes very long to open the preferences window, about 5 seconds with 100% CPU until it comes up, and pressing Apply or Ok even takes longer, about 8 seconds, also with 100% CPU.

Lars Kindermann <larskindermann>
Sun 09 May 2021 08:28:31 AM UTC, comment #6: 

Lars, could you please provide the following additional infos?

  • When does the crash occur? Already when selecting the font in the combo box or only when applying the changes (button "Apply" or "Ok")?
  • Does it also occur when you leave the font as it is but when you change font attributes, size or colors of the style?


Torsten Lilge <ttl>
Group Member
Sun 09 May 2021 02:27:13 AM UTC, comment #5: 

Sudden font change fixed, but the gui still crashes sometimes with signal 11 when changing font in edit - styles preferences.

Lars Kindermann <larskindermann>
Sat 08 May 2021 07:24:56 PM UTC, comment #4: 

Thanks for pointing that out.

I must have done something wrong that I ended up at the other changeset.

I pushed a change that restores it for me here (stupid copy-paste error):
https://hg.savannah.gnu.org/hgweb/octave/rev/0562777c015f

Marking as ready for test.

Markus Mützel <mmuetzel>
Group administrator
Sat 08 May 2021 07:01:45 PM UTC, comment #3: 

Thanks for the report and for further testing.

@Markus: From some test, it seems that cset http://hg.savannah.gnu.org/hgweb/octave/rev/dc171e0452cf
introduced the issues with the lexer settings.

Torsten Lilge <ttl>
Group Member
Sat 08 May 2021 11:20:33 AM UTC, comment #2: 

Might be related to this change:
https://hg.savannah.gnu.org/hgweb/octave/rev/07591becbc40

changeset 29597:07591becbc40

eliminate more child to parent signal/slot connections

* main-window.cc (create_default_editor): Delete.

* file-editor.h, file-editor.cc (file_editor::update_gui_lexer_signal,
file_editor::execute_command_in_terminal_signal,
file_editor::focus_console_after_command_signal,
file_editor::run_file_signal, file_editor::edit_mfile_request,
file_editor::debug_quit_signal): New signals.
(file_editor::make_file_editor_tab): Instead of connecting signals
from the tab to parent object slots, forward through new file_editor
signals.
* main-window.cc (main_window::main_window): Connect file_editor
signals to main_window slots here.
(file_editor::find_create, file_editor::is_editor_console_tabbed,
file_editor::empty_script): Use parentWidget instead of calling
main_win.
author        John W. Eaton <jwe@octave.org>
date        Mon, 03 May 2021 13:30:29 -0400 (4 days ago)
parents        d2b56b5e9d43
children        c7b104ebed4d
files        libgui/src/m-editor/file-editor.cc libgui/src/m-editor/file-editor.h libgui/src/main-window.cc
diffstat        3 files changed, 119 insertions(+), 82 deletions(-) [+]


I had to delete the `octave-gui.ini` file each time when switching the revision.
But changing the editor fonts seems to work reliably before that change and fails (or is less reliable?) after that change.
Once the `octave-gui.ini` file is corrupt(?) by changing the fonts without success, there is no way of reliably changing the fonts even with a revision that seems to work correctly with a "fresh" `octave-gui.ini` file.

Markus Mützel <mmuetzel>
Group administrator
Sat 08 May 2021 10:46:29 AM UTC, comment #1: 

I can confirm on Ubuntu 20.10 with hg id a548bab9eafa.

Markus Mützel <mmuetzel>
Group administrator
Sat 08 May 2021 10:25:29 AM UTC, original submission:  

Current dev suddenly changed the editor fonts.

After deleting the whole .config/octave directory, default fonts are restored. But after quitting/restarting octave the fonts have changed again.

Trying to change fonts in the preferences dialog sometimes has no effect, sometimes crashes the gui.

Lars Kindermann <larskindermann>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by larskindermann (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-05-27 ttl Open/ClosedOpen Closed
    2021-05-27 ttl StatusReady For Test Fixed
    2021-05-08 mmuetzel StatusConfirmed Ready For Test
    2021-05-08 mmuetzel StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code