bugGNU Octave - Bugs: bug #60465, [octave forge] (signal) findpeaks...


bug #60465: [octave forge] (signal) findpeaks should plot data

Submitted by:  None
Submitted on:  Wed 28 Apr 2021 12:23:47 PM UTC  
Category:  Octave Forge Package Severity:  2 - Minor
Priority:  3 - Low Item Group:  Matlab Compatibility
Status:  Confirmed Assigned to:  None
Originator Name:  Originator Email:  -email is unavailable-
Open/Closed:  Open Release:  dev
Operating System:  Any

Add a New Comment (Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Thu 29 Apr 2021 09:51:58 AM UTC, comment #2: 

Found a solution which, solves this problem.

All code changes

if (nargout == 0)
    hold on;
    [pks idx] = findpeaks(data);
    scatter(idx, pks,"v", 'MarkerFaceColor',[0 0 1], "filled")
    clear pks;

New patch is attached.

(file #51333)

Wed 28 Apr 2021 11:23:51 PM UTC, comment #1: 

Confirmed (https://www.mathworks.com/help/signal/ref/findpeaks.html for reference), thanks for the suggestion. Feel free to keep working on this and posting updated patches.

Mike Miller <mtmiller>
Project Administrator
Wed 28 Apr 2021 12:23:47 PM UTC, original submission:  

If findpeaks has no output it should plot the peaks and the data.

Attached is patch attempt of this.
The plotting works but the data is not suppressed.
The markers are not the same colour.




(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #51333:  findpeaks.patch added by None (16KiB - text/x-patch - Version 2)
file #51330:  findpeaks.patch added by None (16KiB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


CC list is empty


Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only project members can vote.




Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2021-04-29 None Attached File- => Added findpeaks.patch, #51333
2021-04-28 mtmiller Severity3 - Normal => 2 - Minor
    Priority5 - Normal => 3 - Low
    StatusNone => Confirmed
    Release4.2.2 => dev
2021-04-28 None Attached File- => Added findpeaks.patch, #51330

Back to the top

Powered by Savane 3.6