bugGNU Octave - Bugs: bug #60298, build with Qt 5.4.broken after...

 
 

bug #60298: build with Qt 5.4.broken after rotated tabs implementation

Submitter:  A.R. Burgers <arb>
Submitted:  Mon 29 Mar 2021 07:08:25 AM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 31 Mar 2021 01:00:56 PM UTC, comment #5: 
Torsten Lilge <ttl>
Group Member
Tue 30 Mar 2021 01:04:56 PM UTC, comment #4: 

yes, fixed with v02 of your patch.

A.R. Burgers <arb>
Tue 30 Mar 2021 11:41:07 AM UTC, comment #3: 

Then it seems that the third argument in the used constructor was not optional in 5.4. Attached a new version of the patch (to be used instead of the first one).

(file #51159)

Torsten Lilge <ttl>
Group Member
Tue 30 Mar 2021 08:41:40 AM UTC, comment #2: 

Applied the patch:


patch -p1 < bug60298_v01.patch
patching file libgui/src/tab-bar.cc


doesn't fix the issue, the output is now:


../octave/libgui/src/tab-bar.cc: In member function 'virtual void octave::tab_bar::mousePressEvent(QMouseEvent*)':
../octave/libgui/src/tab-bar.cc:231:53: error: no matching function for call to 'QAction::QAction(const QIcon&, const QString&)'
  231 |                 QAction* a = new QAction (icon, text);
      |                                                     ^
In file included from /apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qmenu.h:40,
                 from /apps/shared/Qt/5.4/gcc_64/include/QtWidgets/QMenu:1,
                 from ../octave/libgui/src/tab-bar.h:32,
                 from ../octave/libgui/src/tab-bar.cc:33:
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:174:5: note: candidate: 'QAction::QAction(QActionPrivate&, QObject*)'
  174 |     QAction(QActionPrivate &dd, QObject *parent);
      |     ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:174:29: note:   no known conversion for argument 1 from 'const QIcon' to 'QActionPrivate&'
  174 |     QAction(QActionPrivate &dd, QObject *parent);
      |             ~~~~~~~~~~~~~~~~^~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:89:5: note: candidate: 'QAction::QAction(const QIcon&, const QString&, QObject*)'
   89 |     QAction(const QIcon &icon, const QString &text, QObject* parent);
      |     ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:89:5: note:   candidate expects 3 arguments, 2 provided
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:88:5: note: candidate: 'QAction::QAction(const QString&, QObject*)'
   88 |     QAction(const QString &text, QObject* parent);
      |     ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:88:28: note:   no known conversion for argument 1 from 'const QIcon' to 'const QString&'
   88 |     QAction(const QString &text, QObject* parent);
      |             ~~~~~~~~~~~~~~~^~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:87:14: note: candidate: 'QAction::QAction(QObject*)'
   87 |     explicit QAction(QObject* parent);
      |              ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:87:14: note:   candidate expects 1 argument, 2 provided


A.R. Burgers <arb>
Mon 29 Mar 2021 08:56:21 PM UTC, comment #1: 

I am not sure what's going on there since the constructor used for QAction is not documented as recently added to Qt. However, could you please test the attached patch?

(file #51158)

Torsten Lilge <ttl>
Group Member
Mon 29 Mar 2021 07:08:25 AM UTC, original submission:  

The recent change set http://hg.savannah.gnu.org/hgweb/octave/rev/80457383d5e1 breaks building with Qt 5.4 with these errors:


  CXX      libgui/src/libgui_src_libgui_src_la-tab-bar.lo
../octave/libgui/src/tab-bar.cc: In member function 'virtual void octave::tab_bar::mousePressEvent(QMouseEvent*)':
../octave/libgui/src/tab-bar.cc:178:67: error: no matching function for call to 'QAction::QAction(QIcon, QString)'
  178 |                 QAction* a = new QAction (tabIcon (i), tabText (i));
      |                                                                   ^
In file included from /apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qmenu.h:40,
                 from /apps/shared/Qt/5.4/gcc_64/include/QtWidgets/QMenu:1,
                 from ../octave/libgui/src/tab-bar.h:32,
                 from ../octave/libgui/src/tab-bar.cc:33:
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:174:5: note: candidate: 'QAction::QAction(QActionPrivate&, QObject*)'
  174 |     QAction(QActionPrivate &dd, QObject *parent);
      |     ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:174:29: note:   no known conversion for argument 1 from 'QIcon' to 'QActionPrivate&'
  174 |     QAction(QActionPrivate &dd, QObject *parent);
      |             ~~~~~~~~~~~~~~~~^~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:89:5: note: candidate: 'QAction::QAction(const QIcon&, const QString&, QObject*)'
   89 |     QAction(const QIcon &icon, const QString &text, QObject* parent);
      |     ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:89:5: note:   candidate expects 3 arguments, 2 provided
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:88:5: note: candidate: 'QAction::QAction(const QString&, QObject*)'
   88 |     QAction(const QString &text, QObject* parent);
      |     ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:88:28: note:   no known conversion for argument 1 from 'QIcon' to 'const QString&'
   88 |     QAction(const QString &text, QObject* parent);
      |             ~~~~~~~~~~~~~~~^~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:87:14: note: candidate: 'QAction::QAction(QObject*)'
   87 |     explicit QAction(QObject* parent);
      |              ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:87:14: note:   candidate expects 1 argument, 2 provided


A.R. Burgers <arb>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #51159:  bug60298_v02.patch added by ttl (838B - text/x-patch)
file #51158:  bug60298_v01.patch added by ttl (913B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Updated the item)
  • -email is unavailable- added by arb (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-03-31 ttl StatusNone Fixed
        Open/ClosedOpen Closed
    2021-03-30 ttl Attached File- Added bug60298_v02.patch, #51159
    2021-03-29 ttl Attached File- Added bug60298_v01.patch, #51158

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code