bugGNU Octave - Bugs: bug #60170, [MXE Octave] Add of-octproj package

 
 

bug #60170: [MXE Octave] Add of-octproj package

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Thu 04 Mar 2021 04:21:35 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  John Donoghue <lostbard>
Originator Name:  Philip Nienhuis Open/Closed:  Closed
Release:  other Operating System:  Microsoft Windows

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 08 Mar 2021 08:55:18 PM UTC, comment #12: 

Works fine, thanks very much gentlemen.

Closing report as "Fixed".

Philip Nienhuis <philipnienhuis>
Project Member
Sat 06 Mar 2021 11:45:13 PM UTC, comment #11: 

Off-topic alert 😇

Can you continue the general mxe discussion here:
https://octave.discourse.group/t/mxe-octave-default-and-release-branch/854/16

Otherwise I am afraid this discussion is lost once this bug is resolved.

Kai Torben Ohlhus <siko1056>
Project Member
Sat 06 Mar 2021 07:55:22 PM UTC, comment #10: 

i agree with the fix bugs and keep the main changes for major releases, there are perhaps a few packages that updating to the latest version is the bug fix, but as general rule for most thats fine.

I generally build using stable octave, but with the default mxe branch for my testing, but usually only for x86-64

John Donoghue <lostbard>
Project MemberIn charge of this item.
Sat 06 Mar 2021 06:14:37 PM UTC, comment #9: 

Does building stable or default Octave in mxe-octave also differ w.r.t. Octave-Forge package? If so, I never noticed.

FWIW I usually have the very latest fixes for several OF packages in my build, notably the packages I'm using or busy with (io, mapping statistics, signal and linear-algebra).

If I want a stable release Octave for some reason (happens rarely) I just edit the Makefile by hand to change OCTAVE_TARGET.
In the past I kept stable and default versions side by side (patch #8469) but these days I don't care too much :-), I just renew my mxe build tree every other month.

Philip Nienhuis <philipnienhuis>
Project Member
Sat 06 Mar 2021 02:44:30 PM UTC, comment #8: 

Tbh, I haven't thought this far ahead yet.

IIUC, jwe preferred to not have too many changes in the Windows bundle between dot-releases. I kind of agree that it'd probably make sense to only fix bugs (and update Octave Forge packages) similarly to what we do on Octave's stable branch.
It might make sense to wait until a major release with other updates that aren't needed for fixing bugs.

We should probably merge the default to the release branch in the MXE Octave repository some time between just after merging default to stable in the Octave repository (probably the earliest it'd make sense) and just before the first release candidate (probably the latest opportunity).
I'd vote for not waiting too long to have sufficient time for testing.

IIRC, jwe wrote about switching his buildbots to the release branch for the stable and release targets. The default targets on his buildbots would still use the default branch of MXE Octave.

I don't know what Kai Torben decided to do for his nightly builds. But if he keeps tracking the default branch of MXE Octave, any changes on there would still be tested with the current stable branch of Octave.
In that case, we'd probably have a good enough test coverage on both branches.

What do you think?

Markus Mützel <mmuetzel>
Project Member
Sat 06 Mar 2021 02:00:28 PM UTC, comment #7: 

What will be the schedule for merging default branch of everything else to release ? The same time as when octave 7 gets  prepped for release ?

John Donoghue <lostbard>
Project MemberIn charge of this item.
Sat 06 Mar 2021 12:41:04 PM UTC, comment #6: 

I grafted the recent updates of Octave Forge packages to the release branch.
It is probably ok to update Octave Forge packages on the release branch directly and merged the changes to default if possible.
Please, let me know what you think about having those two branches in the MXE Octave repository.

Markus Mützel <mmuetzel>
Project Member
Fri 05 Mar 2021 02:23:04 PM UTC, comment #5: 

pushed up

John Donoghue <lostbard>
Project MemberIn charge of this item.
Fri 05 Mar 2021 01:58:39 PM UTC, comment #4: 

The reason was that new packages were just appended to the list, rather than inserting in any order.

At one point I had been adding any octave forge packages required by a package as a package dependency which would effect their build order, but not sure if that was done on all of them.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Fri 05 Mar 2021 01:20:32 PM UTC, comment #3: 

I think it does, thanks. I'd say just push.

BTW, is there a reason that OF package names occur in a seemingly random order in the OCTAVE_FORGE_PACKAGES macro in Makefile.in ?
ISTR they're built "directly" (w/o pkg.m operation) so if that's correct they could be in alphabetical order as well.

Philip Nienhuis <philipnienhuis>
Project Member
Thu 04 Mar 2021 10:44:29 PM UTC, comment #2: 

This may work

(file #50990)

John Donoghue <lostbard>
Project MemberIn charge of this item.
Thu 04 Mar 2021 05:37:04 PM UTC, comment #1: 

AFAICT, all dependencies that are needed to install octproj are already there (i.e., the `proj` library).
It installs without issue for me with `pkg install -forge octproj` and all tests seem to pass.

We already bundle the `mapping` package. If you plan to add a dependency on `octproj`, we'd need to bundle this package anyway to avoid issues when loading that package.

Adding it to the bundle should be straightforward.

Markus Mützel <mmuetzel>
Project Member
Thu 04 Mar 2021 04:21:35 PM UTC, original submission:  

In the course of adding projection functions to the mapping package the octproj package could serve nicely as a dependency.
Would it be possible to add octproj to mxe-octave?

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #50990:  octproj.patch added by lostbard (4KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by lostbard (Updated the item)
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-03-08 philipnienhuis StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2021-03-05 lostbard StatusPatch Submitted => Ready For Test
        Assigned toNone => lostbard
    2021-03-05 mmuetzel Summary[octave forge] (octproj) Add octproj package to mxe-octave => [MXE Octave] Add of-octproj package
    2021-03-04 lostbard Attached File- => Added octproj.patch, #50990
        StatusNone => Patch Submitted
    2021-03-04 mmuetzel Operating SystemAny => Microsoft Windows
    2021-03-04 mmuetzel Summary(octave-forge)[octproj) Add octproj package to mxe-octave => [octave forge] (octproj) Add octproj package to mxe-octave

    Back to the top


    Powered by Savane 3.6