bugGNU Octave - Bugs: bug #60051, When closing all editor tabs,...

 
 

bug #60051: When closing all editor tabs, these are still restored at next startup

Submitter:  Hartmut <hardy>
Submitted:  Sat 13 Feb 2021 06:01:03 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 6.1.0 Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 15 Feb 2021 06:11:40 PM UTC, comment #9: 

Thanks for testing, I will close the issue as fixed.

Regarding the second issue: The empty variable editor is really sometimes confusing with its completely inactive and unresponsive layout.

Torsten Lilge <ttl>
Group Member
Mon 15 Feb 2021 08:27:50 AM UTC, comment #8: 

I have now compiled and tested an Octave version including Torsten's fix from comment #6 (hg-id fd1c45b62ba9).

  • The behavior of the GUI editor, when closing all m-file tabs, is now as expected. So my (first) issue is fixed.
  • make check still finishes without any failing tests.


I think this issue can now be closed as FIXED.

Thanks again for the fast code change, Torsten. And sorry for my embarrasing misconception regarding my second "issue".

Hartmut <hardy>
Sun 14 Feb 2021 10:43:25 PM UTC, comment #7: 

Wow, this was a fast fix. Thanks! I will build dev Octave (stable branch) overnight in order to test it and let you then know the result.

Hartmut <hardy>
Sun 14 Feb 2021 09:50:26 PM UTC, comment #6: 

The remaining issue is fixed with cset
http://hg.savannah.gnu.org/hgweb/octave/rev/fd1c45b62ba9

Torsten Lilge <ttl>
Group Member
Sun 14 Feb 2021 08:08:35 PM UTC, comment #5: 

First issue: OK. That's the topic of this bug report now.

Second issue: I've now retested with older versions of Octave, and there is no change in behavior, so no regression. I would still prefer Octave to restore the GUI tabs in the order they were during the last shutdown. But that would then be a feature request and no bug report, so let's just drop it here.

Hartmut <hardy>
Sun 14 Feb 2021 06:10:49 PM UTC, comment #4: 

First issue, restore closed files: Okay, I misinterpreted your original post. When I close all tabs of the editor, all closed files are restored at next startup. When I close only some of several tabs, these files are not restored.
I have changed the status to confirmed and updated the title to better reflect this issue.

Second Issue, empty editor: What you are seeing in GUI@without@editor is the variable editor, which always is empty at startup. The file editor's tab is hidden behind the one of the variable editor.


Torsten Lilge <ttl>
Group Member
Sun 14 Feb 2021 05:53:13 PM UTC, comment #3: 

Oh wait, blame on me. I just understood what went wrong, concerning my second issue: I have three "application tabs" in the upper right corner of the Octave GUI, the editor, the help and the variable editor. And the only problem is, that after restart always the right-most tab gets set to the front. So the editor tab, which happens to be the middle tab, is "invisible" to me at startup. It would (and does!) also help when I only click onto the editor tab, then it becomes visible. The empty box I have seen is not the editor  pane, but the (empty) variable editor at startup.

Nevertheless I think this behavior might still be a regression. Because when I remember right older Octave versions would restore the GUI windows layout precisely, and also highlight the GUI tab that was highlighted at Octave shutdown, even if it was not the rightmost tab. Whould this qualify as something reproducible and useful to fix?

(I still have no clue what happens with my "fist issue" of re-appearing closed m-file tabs. Any hints what to "play with" in this case?)


Hartmut <hardy>
Sun 14 Feb 2021 05:41:48 PM UTC, comment #2: 

I am not sure if there has already been another bug report on these issues. I had only seen two of your commits in the repo some weeks ago (be61ce9c3126 and bd5961abe971) and was assuming they were intending to fix this behavior I observed with Octave 6.1.0. But looking a bit close, those commits are linked to bug #59628, and I am not sure of this is the same problem at all.

first issue: Yes I can reproduce this every single time on my linux machine. When I have one (or also several) m-files open in tabs of the m-file editor, then close all those tabs, and afterwards close the Octave GUI, then those closed tabs will "magically" (but unwantedly) re-appear after a restart of Octave.

second issue: This happens repeatedly on my Win10 installation of Octave: In the issue I meant, the edit widget is still present in the GUI layout. It is just totally empty. I will attach a screenshot to show what I mean  ("GUI without editor.png")

For the second issue I "played" a bit with the GUI layout (Win10), according to your suggestions, the results might be helpful to reproduce this:

  • On startup of the Octave GUI the editor pane is there but empty. (Screenshot "without editor").
  • When I emit the command "edit" directly after GUI startup, then the editor pane content appears (see screenshot "after edit command").
  • I can also (directly after startup) press Ctrl-4 instead, this also make the editor pane content appear.
  • When I reset the windows layout to default (by the corresponding menu entry), then the editor pane becomes also fully visible. So far so good. But there are interesing tweaks to it:
    • When I stick to this "default GUI layout", then the editor pane stay fully visible even after a restart of the Octave GUI. Good.
    • When I re-arrange the GUI, to have the editor pane in the top right quarter of the GUI, and leave everything else as in the default layout, then the editor pane also stays visible (and full) after restart. Good as well.
    • BUT: When I re-arrange all the GUI panes as I had them before (my favorit GUI layout), you can see how this looks like in the sceenshots, then the editor pane again becomes empty after restart!


So this behavior seems to have something to do with the precise Windows pane layout you choose inside the Octave GUI. Can someone now reproduce this "akward" behavior with the editor pane, when using the SAME window layout as I do (as can be seen in my screenshots)?


Hartmut <hardy>
Sat 13 Feb 2021 08:02:06 PM UTC, comment #1: 

Thanks for the report. You are saying that you were hoping that this would be fixed in 6.2.0. Is there an existing report on this issue?

  • I can not reproduce the first issue with a current build from the stable branch. Does the issue always show up or does this depend on the number of open files?
  • The second issue as described in your report never happened to me. Have you tried to restore the editor by Ctrl-4 or by resetting the window layout in the window menu of the main window? Is the editor itself hidden or is the widget shown, but completely empty?


Torsten Lilge <ttl>
Group Member
Sat 13 Feb 2021 06:01:03 PM UTC, original submission:  

I observe two "akward" behaviors in Octave's GUI editor pane.

This happens under Windows 10 as well as under Ubuntu linux with the current release candidate Octave 6.1.90. Here is what I mean:

  • Open an m file in the GUI editor pane. Use the Octave settings "remember open m-files in editor". Close this tab of the m-file in the editor. Close and restart Octave. Result: The m-file does re-open in the editor pane. (But it should stay closed).


  • I also managed to fully remove the GUI content of the editor pane. (I am not quite sure what I did, but only "normal usage".) Not only are all m-file tabs now closed, but also the editor stuff itself is invisible (no menu, no icon buttons). After every start of Octave (GUI) I need to type "edit" into the console, in order to generate the empty GUI editor console. Only then can I open m-files in the GUI editor.


This "akward" behavior has already been present in Octave 6.1.0, but I think it was ment to be fixed (I remember to have seen it somewhere in the repo some weeks ago), but now I STILL see it in the current release candidate 6.1.90.

Can anyone else see this? Does this has to do with the Qt version change we did for Octave 6.1.90?

I would really like to see this fixed, this bothers me a hundred times a day when using Octave. My hope was, that 6.2.0 will have it fixed anyways, but now this bug seems to be still staying.

Hartmut <hardy>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #50861:  GUI@without@editor.png added by hardy (72KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by hardy (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-02-15 ttl StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2021-02-14 ttl StatusConfirmed Ready For Test
    2021-02-14 ttl StatusNeed Info Confirmed
        Summaryawkward behavior of GUI editor pane (in Octave 6.1.90) When closing all editor tabs, these are still restored at next startup
    2021-02-14 hardy Attached File- Added GUI@without@editor.png, #50861
        Attached File- Added GUI@after@edit@command.png, #50862
    2021-02-13 rik5 Carbon-CopyRemoved 72865 -
    2021-02-13 rik5 Summaryakward behavior of GUI editor pane (in Octave 6.1.90) awkward behavior of GUI editor pane (in Octave 6.1.90)
    2021-02-13 ttl StatusNone Need Info

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code