bugGNU Octave - Bugs: bug #59784, additional text at end of block...

 
 

bug #59784: additional text at end of block comment produces doubled warning

Submitted by:  Rik <rik5>
Submitted on:  Wed 30 Dec 2020 05:13:45 PM UTC  
 
Category:  Interpreter Severity:  2 - Minor
Priority:  3 - Low Item Group:  Other
Status:  Confirmed Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 13 Feb 2021 10:00:20 PM UTC, comment #2: 

I pushed a change to the warning message here (http://hg.savannah.gnu.org/hgweb/octave/rev/30afb3804d6e).  Incidentally, Matlab doesn't let the programmer get away with unterminated block comments.  It throws an error, rather than a warning, at the end of input.

Rik <rik5>
Project Administrator
Sat 13 Feb 2021 09:43:12 PM UTC, comment #1: 

I think the fact that we are getting two messages printed is due to an actual misunderstanding in using bison parser.  The code in lex.ll is

<<EOF>> {
   return curr_lexer->handle_end_of_input ();
  }

I used a debugger with a breakpoint in handle_end_of_input and the function is called twice from this location.

I suspect the problem is that when EOF is encountered the token is somehow not being popped off the stack (possibly because of the return statement).  Or in some other way we are not marking that we should abandon processing.  Adding jwe to the CC list since he might understand what is going on.

Rik <rik5>
Project Administrator
Wed 30 Dec 2020 05:13:45 PM UTC, original submission:  

This isn't a big deal, but consider the script below.

#{
comment line
#} disp ('out of block comment');

When the script is run the output from the interpreter is:

warning: block comment open at end of input
warning: near line 4 of file 'dbl_msg_print.m'
warning: block comment open at end of input
warning: near line 4 of file 'dbl_msg_print.m'

I get that the interpreter is unhappy, but it really only needs to print the message once.

On a second note, I think the warning message could be clearer.  Maybe something like

warning: trailing text after block comment close

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-02-13 rik5 Carbon-Copy- => Added jwe
    2021-01-04 rik5 Priority5 - Normal => 3 - Low

    Back to the top


    Powered by Savane 3.5