bugGNU Octave - Bugs: bug #59051, [octave forge] (optim)...

 
 

bug #59051: [octave forge] (optim) "quadprog" fails due to changed signature of "__qp__"

Submitted by:  Markus Mützel <mmuetzel>
Submitted on:  Tue 01 Sep 2020 03:30:57 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  6.0.90 Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 06 Sep 2020 03:46:47 PM UTC, comment #1: 

Thanks for reporting. I did it a bit different to avoid masking any errors with try/catch.

Fixed with:

https://sourceforge.net/p/octave/optim/ci/0b225df4fb4d760b772708cfe09bb1700da56726/

Olaf Till <i7tiol>
Project Member
Tue 01 Sep 2020 03:30:57 PM UTC, original submission:  

Call "quadprog" fails because the function signature of the internal function "__qp__" has changed in Octave 6. The new signature also expects a 9th argument "rtol".

I'm not sure how to ask for the function signature of a built-in function. ´nargin("quadprog")´ won't work.
The following change works for me. But maybe there is a better solution:

--- "a/quadprog.m"
+++ "b/quadprog.m"
@@ -349,8 +349,13 @@ function varargout = quadprog (H, f, varargin)
   if (exitflag == 0)
     ## The initial (or computed) guess is feasible.
     ## We call the solver.
-    [x, qp_lambda, exitflag, iter] = ...
-    __qp__ (x0, H, f, Aeq, beq, Ain, bin, maxit);
+    try
+      [x, qp_lambda, exitflag, iter] = ...
+        __qp__ (x0, H, f, Aeq, beq, Ain, bin, maxit, rtol);
+    catch
+      [x, qp_lambda, exitflag, iter] = ...
+        __qp__ (x0, H, f, Aeq, beq, Ain, bin, maxit);
+    end_try_catch

   else
     iter = 0;

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by i7tiol (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-09-06 i7tiol StatusNone => Fixed
        Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5