bugGNU Octave - Bugs: bug #58821, Figure attributes no longer work

 
 

bug #58821: Figure attributes no longer work

Submitter:  Michael Godfrey <godfrey>
Submitted:  Fri 24 Jul 2020 05:03:31 PM UTC
   
 
Category:  Plotting with OpenGL Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  godfrey Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 24 Jul 2020 05:52:46 PM UTC, comment #5: 

I checked in another set of changes to various other graphics callbacks here https://hg.savannah.gnu.org/hgweb/octave/rev/4deb794d85e2.

I'll close this report for now, although there still may be some instances that will only get caught by running code.  For example, the packages on Octave Forge may need to be updated before the 7.1 release for this same issue.

Rik <rik5>
Group administrator
Fri 24 Jul 2020 05:43:19 PM UTC, comment #4: 

Works for me!  Thanks. OK to close as far as I know.

Michael Godfrey <godfrey>
Group Member
Fri 24 Jul 2020 05:27:33 PM UTC, comment #3: 

Yes, I didn't catch all of these cases.

Rik's change is what I was about to do.

I'm not sure of a way to find all these cases automatically.

John W. Eaton <jwe>
Group administrator
Fri 24 Jul 2020 05:23:47 PM UTC, comment #2: 

This changeset should fix the issue you discovered (https://hg.savannah.gnu.org/hgweb/octave/rev/6e8d14f4fb2f).  I'll see if I spot any other problems with grep.

Rik <rik5>
Group administrator
Fri 24 Jul 2020 05:19:10 PM UTC, comment #1: 

Confirmed.  It was probably this changeset from jwe to have better Matlab compatibility:


changeset:   28562:b0b80efecea1
user:        John W. Eaton <jwe@octave.org>
date:        Sat Jul 11 09:34:44 2020 -0400
summary:     error for functions called with too many inputs or outputs


The issue is the graphics callback functions defined as subfunctions in _add_default_menu_.m.  The function prototype is


function grid_cb (h)


but all graphics callbacks are invoked by the interpreter as


callback (graphic_handle, event_structure)


Changing the function prototype to


function grid_cb (h, ~)


restores functionality.

Except for a few graphics callbacks, the event_structure input is unused and unfilled.  I think going through the code and verifying the callbacks all have '~' as the second argument will fix this.

Rik <rik5>
Group administrator
Fri 24 Jul 2020 05:03:31 PM UTC, original submission:  

Clicking on figure attributes no longer works:

error: grid_cb: function called with too many inputs
error: called from
    _add_default_menu_>grid_cb
octave:2> version -hgid
ans = e70c859c4bff
octave:3>

An update within the last few days has introduced this.
None of the attributes work.

Michael Godfrey <godfrey>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by godfrey (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-24 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2020-07-24 rik5 StatusConfirmed Ready For Test
    2020-07-24 rik5 StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code