bugGNU Octave - Bugs: bug #58549, build failure related to hdf5

 
 

bug #58549: build failure related to hdf5

Submitter:  A.R. Burgers <arb>
Submitted:  Fri 12 Jun 2020 07:51:30 AM UTC
   
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 6.0.90 Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 12 Jun 2020 05:56:49 PM UTC, comment #4: 

Thanks for the confirmation.

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Fri 12 Jun 2020 01:28:02 PM UTC, comment #3: 

yes, that fixes the issue.

A.R. Burgers <arb>
Fri 12 Jun 2020 09:37:36 AM UTC, comment #2: 

Should be fixed with this change:
https://hg.savannah.gnu.org/hgweb/octave/rev/1ab57f86aac6

Marking as ready for test.

Could you please confirm if this fixes the issue for you?

Markus Mützel <mmuetzel>
Group administrator
Fri 12 Jun 2020 08:48:19 AM UTC, comment #1: 

We had the same issue in MXE Octave before updating hdf5 to a newer version.

The reason why this works with some versions of hdf5 and doesn't with others is that the type of hid_t changed between versions.

I'll have a look how we could restore compatibility with older hdf5 versions.

Markus Mützel <mmuetzel>
Group administrator
Fri 12 Jun 2020 07:51:30 AM UTC, original submission:  

current stable HG-ID 0d56bfb63b90 fails to build for me with this error:


  CXX      libinterp/octave-value/libinterp_octave_value_liboctave_value_la-ov-fcn-handle.lo
../octave_stable/libinterp/octave-value/ov-fcn-handle.cc: In member function 'virtual bool octave_fcn_handle::load_hdf5(octave_hdf5_id, const char*)':
../octave_stable/libinterp/octave-value/ov-fcn-handle.cc:2860:31: error: cannot bind non-const lvalue reference of type 'octave_hdf5_id&' {aka 'long int&'} to an rvalue of type 'octave_hdf5_id' {aka 'long int'}
 2860 |       if (new_rep->load_hdf5 (group_hid, space_hid, type_hid))
      |                               ^~~~~~~~~
../octave_stable/libinterp/octave-value/ov-fcn-handle.cc:663:31: note:   initializing argument 1 of 'virtual bool octave::base_fcn_handle::load_hdf5(octave_hdf5_id&, octave_hdf5_id&, octave_hdf5_id&)'
  663 |   base_fcn_handle::load_hdf5 (octave_hdf5_id&, octave_hdf5_id&, octave_hdf5_id&)
      |                               ^~~~~~~~~~~~~~~
make[2]: *** [libinterp/octave-value/libinterp_octave_value_liboctave_value_la-ov-fcn-handle


A.R. Burgers <arb>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by arb (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-06-12 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2020-06-12 mmuetzel StatusNone Ready For Test

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code