bugGNU Octave - Bugs: bug #58543, inline functions don't accept...

 
 

bug #58543: inline functions don't accept arguments on Windows

Submitter:  Markus Mützel <mmuetzel>
Submitted:  Thu 11 Jun 2020 01:48:12 PM UTC
   
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 6.0.90 Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sat 13 Jun 2020 02:56:05 PM UTC, comment #6: 

Works for me now.
Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Sat 13 Jun 2020 02:20:35 PM UTC, comment #5: 

@Markus: You were re-building your MXE environment.  Do inline functions work again and can we shut this report down?

Rik <rik5>
Group administrator
Thu 11 Jun 2020 03:47:27 PM UTC, comment #4: 

Don't worry. Your changes are very much appreciated.
Like with the previous test on your private branch, Octave is much more "snappy" than it was before on Windows.

I had a few more failing tests on Windows. But those are most probably because I used a "contaminated" MXE build tree for the initial tests. I'm re-building from a clean tree right now. But that might take a while.

Markus Mützel <mmuetzel>
Group administrator
Thu 11 Jun 2020 03:04:12 PM UTC, comment #3: 

Thanks for this and the other cleanup patches you pushed today.  I probably should have tried to run make dist and verify that all the files were included.  Oops.

John W. Eaton <jwe>
Group administrator
Thu 11 Jun 2020 02:14:36 PM UTC, comment #2: 

Well this was easier than I initially thought.
Hopefully this is fixed with this change:
https://hg.savannah.gnu.org/hgweb/octave/rev/2396ee754ce8

Marking as ready for test.

Markus Mützel <mmuetzel>
Group administrator
Thu 11 Jun 2020 02:00:22 PM UTC, comment #1: 

That's definitely surprising.  It looks like the variable "a" is actually an array, not a classsdef object, but that doesn't make sense because you just defined it with inline.

Can you try setting debug_on_error (true) and maybe verify that the error is actually coming from inside the @inline/subsref method or somewhere else?

John W. Eaton <jwe>
Group administrator
Thu 11 Jun 2020 01:48:12 PM UTC, original submission:  

Function handles created with the "inline" function cannot be called with input arguments on Windows:

>> a = inline ("islogical (x)", "x")
a =

  <class inline>

>> a(0.1)
error: a(0.1): subscripts must be either integers 1 to (2^63)-1 or logicals
>> a('foo')
error: a(111): out of bound 1 (dimensions are 1x1)


Tested with hg id b659b7f085c6 (on the default branch).
I haven't tested with the stable branch. But I suspect it would be the same.

The same test works on Ubuntu using the same hg id.

It might be related to this change:
https://hg.savannah.gnu.org/hgweb/octave/rev/7a8c69c4eb55
convert obsolete octave_fcn_inline object to @inline class
author John W. Eaton <jwe@octave.org>
date Mon, 23 Mar 2020 15:29:49 -0400 (2 months ago)

Markus Mützel <mmuetzel>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-06-13 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2020-06-11 mmuetzel StatusNone Ready For Test

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code