bugGNUstep - Bugs: bug #58190, NSLocale/general.m test still...

Group
 
 

bug #58190: NSLocale/general.m test still fails with ICU >= 65

Submitter:  Yavor Doganov <yavor>
Submitted:  Thu 16 Apr 2020 01:54:04 PM UTC
   
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 11 Jun 2020 05:03:15 PM UTC, comment #2: 

Thanks; works for me.

Yavor Doganov <yavor>
Sat 09 May 2020 03:19:21 PM UTC, comment #1: 

I followed your idea to mark these tests as hopeful. That way we still have the tests and they no longer should stop your tests before the installation of base. Please give it a try.

Fred Kiefer <FredKiefer>
Group Member
Thu 16 Apr 2020 01:54:04 PM UTC, original submission:  

This was initially reported at https://github.com/gnustep/libs-base/issues/103 and fixed in commit 5248b6e.  Unfortunately the fix doesn't work when building in a chroot (as is the case for the Debian package) because Locale.canonical is not installed when the testsuite is being run.  Therefore I propose to use the new locale identifier as in the attached patch and as suggested by user xnox in the issue above.  It should work with all supported ICU versions.

If the old mapping needs to be tested as well, it may be done as an additional test marked as hopeful or guarded by the appropriate ICU version check.

Yavor Doganov <yavor>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rmottola (Updated the item)
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by yavor (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-12-17 rmottola StatusReady For Test Fixed
        Open/ClosedIn Test Closed
    2020-05-09 FredKiefer StatusNone Ready For Test
        Assigned toNone FredKiefer
        Open/ClosedOpen In Test
    2020-04-16 yavor Attached File- Added 0001-Use-new-locale-identifier-for-NSLocale-test-should-w.patch, #48848

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code