bugGNU Octave - Bugs: bug #57835, griddata3: fails to pass method to...

 
 

bug #57835: griddata3: fails to pass method to griddatan

Submitted by:  Nicholas Jankowski <nrjank>
Submitted on:  Mon 17 Feb 2020 02:05:10 AM UTC  
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Nicholas Jankowski Open/Closed:  Closed
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 18 Feb 2020 03:50:16 AM UTC, comment #2: 

Good catch.  It also looks as if griddata3 has been deprecated.  I don't see it in the list of functions, and griddata in Matlab now supports 2-D and 3-D data.  I'll file a separate bug report about that.

After review, I pushed your patch to the stable branch here https://hg.savannah.gnu.org/hgweb/octave/rev/739045a86cfd.

Marking as fixed and closing report.

Rik <rik5>
Project Administrator
Mon 17 Feb 2020 02:11:36 AM UTC, comment #1: 

patch attached

(file #48429)

Nicholas Jankowski <nrjank>
Mon 17 Feb 2020 02:05:10 AM UTC, original submission:  

in line 77, griddata3 calls griddatan to do the actual processing. However, because method is not part of varargin, it never gets passed. Attached is a small bugfix m-file that respects 'method' including defaulting and passing linear if unspecified. BIST testing 'nearest' method is now also correct.

will attach patch once bug # generated

Nicholas Jankowski <nrjank>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #48429:  griddata3fix.diff added by nrjank (1KiB - application/octet-stream)
file #48428:  griddata3.m added by nrjank (4KiB - text/plain)

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by nrjank (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-03-10 rik5 Dependencies- => bugs #57323 is dependent
    2020-02-18 rik5 StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2020-02-17 siko1056 StatusNone => Patch Submitted
    2020-02-17 nrjank Attached File- => Added griddata3fix.diff, #48429
    2020-02-17 nrjank Attached File- => Added griddata3.m, #48428

    Back to the top


    Powered by Savane 3.5