bugGNU Octave - Bugs: bug #57816, [octave forge] (communications)...

 
 

bug #57816: [octave forge] (communications) macro redefinition warning when installing on 4.4.1

Submitter:  Andrew Janke <apjanke>
Submitted:  Sat 15 Feb 2020 03:33:20 AM UTC
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Confirmed Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * 4.4.1 Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Sat 15 Feb 2020 08:32:38 PM UTC, comment #2: 

Confirmed on Debian, installation succeeds and it's probably doing the right thing, but the warning should be addressed.

Mike Miller <mtmiller>
Project Administrator
Sat 15 Feb 2020 04:29:50 AM UTC, comment #1: 

Here's the warning:

>> pkg install -forge communications
gf.cc:47:9: warning: 'OCTAVE__ERR_SQUARE_MATRIX_REQUIRED' macro redefined [-Wmacro-redefined]
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) err_square_matrix_required(a, "")
        ^
gf.cc:43:9: note: previous definition is here
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) gripe_square_matrix_required(a)
        ^
1 warning generated.

Here's the code:

#ifdef HAVE_OCTAVE_GRIPES_H
#include <octave/gripes.h>
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) gripe_square_matrix_required(a)
#endif
#ifdef HAVE_OCTAVE_ERRWARN_H
#include <octave/errwarn.h>
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) err_square_matrix_required(a, "")
#endif

Maybe HAVE_OCTAVE_GRIPES_H and HAVE_OCTAVE_ERRWARN_H are not mutually exclusive, and that should be an "#else ifdef" or something there?

Andrew Janke <apjanke>
Sat 15 Feb 2020 03:33:20 AM UTC, original submission:  

When installing package communications on Octave 4.4.1 on macOS 10.14, I get this warning about a redefined macro:

>> pkg install -forge communications
gf.cc:47:9: warning: 'OCTAVE__ERR_SQUARE_MATRIX_REQUIRED' macro redefined [-Wmacro-redefined]
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) err_square_matrix_required(a, "")
        ^
gf.cc:43:9: note: previous definition is here
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) gripe_square_matrix_required(a)
        ^
1 warning generated.
+verbatim+

Here's the code in gf.cc:

+verbatim+
#ifdef HAVE_OCTAVE_GRIPES_H
#include <octave/gripes.h>
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) gripe_square_matrix_required(a)
#endif
#ifdef HAVE_OCTAVE_ERRWARN_H
#include <octave/errwarn.h>
#define OCTAVE__ERR_SQUARE_MATRIX_REQUIRED(a) err_square_matrix_required(a, "")
#endif
+verbatim+

Sounds like HAVE_OCTAVE_GRIPES_H and HAVE_OCTAVE_ERRWARN_H are not mutually exclusive? Maybe that should be an "#else ifdef HAV_OCTAVE_ERRWARN_H" in there?

Andrew Janke <apjanke>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by apjanke (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-02-15 mtmiller StatusNone Confirmed
        Operating SystemMac OS Any
        Summarymacro redefinition warning when installing communications 1.2.2 on 4.4.1 [octave forge] (communications) macro redefinition warning when installing on 4.4.1

    Back to the top


    Powered by Savane 3.9