bugGNU Octave - Bugs: bug #57779, [octave forge] (geometry) Unit...

 
 

bug #57779: [octave forge] (geometry) Unit tests in svg.m fail

Submitted by:  Rafael Laboissiere <rlaboiss>
Submitted on:  Sun 09 Feb 2020 05:24:52 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Confirmed Assigned to:  Juan Pablo Carbajal <juanpi>
Originator Name:  Open/Closed:  Closed
Release:  other Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 12 Feb 2020 09:52:40 AM UTC, comment #5: 

Thanks Rafael,

I am aware of this, and decided to put everything as xtest because the I consider whole class broken. I need to decide if inkscape is a recommended (or soft?) dependency (in which case I need to use system libraries) or if I include the relevant file (now a C++ library) in the package.

In any case the svg class will need re-writing to use oct files instead of python.

Also, maybe you known another simple read-write library for svg classes, instead of Inkscape. I like the implementation in Inkscape because it is concerned with the numerics and not with the visalization, as e.g. gl2ps. Also it covers almost all features of current svg standard.

Juan Pablo Carbajal <juanpi>
Project MemberIn charge of this item.
Tue 11 Feb 2020 10:39:13 AM UTC, comment #4: 

Thanks, Juan.  I took a look at your commit bd57b4.  I think that only the two last tests needed to be changed to xtest.  The first test, involving file drawing5.svg, seems to work fine.

Rafael Laboissiere <rlaboiss>
Tue 11 Feb 2020 09:27:19 AM UTC, comment #3: 

Thanks for pointing this out.

I changed test in svg.m to xtest. The commit is
bd57b4b02ef3 in the release bookmark

Juan Pablo Carbajal <juanpi>
Project MemberIn charge of this item.
Mon 10 Feb 2020 07:05:39 PM UTC, comment #2: 

It's probably best to change the known failing tests from %!test to %!xtest until they can be fixed.

Mike Miller <mtmiller>
Project Administrator
Sun 09 Feb 2020 08:40:01 PM UTC, comment #1: 

FTR, this was explicitly mentioned in the announcement:
https://octave.1599824.n4.nabble.com/geometry-4-0-0-released-tt4695649.html

If there was no bug report yet for this issue this report can serve as a reminder.

Philip Nienhuis <philipnienhuis>
Project Member
Sun 09 Feb 2020 05:24:52 PM UTC, original submission:  

Two unit tests in file @svg/svg.m are not working for
geometry 4.0.0 and Octave 5.1.0. Here is how to reproduce the bugs:

$ octave-cli -q
octave:1> pkg load geometry
octave:2> dc = svg('drawing6.svg');
octave:3> ids = dc.pathid();
octave:4> P = dc.path2polygon(ids{1});
error: cat: dimension mismatch
error: called from
    cell2mat at line 80 column 11
    shape2polygon at line 34 column 11
    path2polygon at line 26 column 5
    subsref>@<anonymous> at line 30 column 45
    subsref at line 71 column 11
octave:4> dc = svg('drawing6.svg');
octave:5> dc.plot();
error: matrix cannot be indexed with .
error: called from
    plot at line 25 column 7
    plot at line 50 column 7
    subsref>@<anonymous> at line 27 column 37
    subsref at line 69 column 10

Rafael Laboissiere <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by juanpi (Posted a comment)
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-02-11 juanpi Assigned toNone => juanpi
        Open/ClosedOpen => Closed
    2020-02-10 mtmiller StatusNone => Confirmed

    Back to the top


    Powered by Savane 3.5