I pushed another change on the stable branch

https://hg.savannah.gnu.org/hgweb/octave/rev/44a019d01aa5

This fixes all remaining spelling errors that codespell shows me on stable, and the default branch looks good to me now as well, so I think we can call this done.

Attached this time.

(file #48263)

Little bit off topic:  I recently pushed a documentation change and hope as non-native English speaker to not have introduced too many new spelling and grammar errors.  Only the first subsections of section "11 Functions and scripts" are affected.  If you could shortly review?

https://hg.savannah.gnu.org/hgweb/octave/rev/8a07553faf2b

Thank you.

Regarding comment #12 and comment #13.  I dare to speak that the affected "tesselate" classes are not part of the public API, only one forward declaration could be included in an installed version of Octave dev:

$ cd octave/dev/install/default
$ grep -R "tessela"
share/octave/6.0.0/m/plot/draw/shrinkfaces.m:%! title ("shrinkfaces() on 2-D complex shapes tesselated with triangles");
Binary file lib64/octave/6.0.0/liboctinterp.so.7.0.1 matches
Binary file lib64/octave/6.0.0/liboctinterp.so.7 matches
Binary file lib64/octave/6.0.0/liboctinterp.so matches
include/octave-6.0.0/octave/gl-render.h:    class patch_tesselator;

I also intentionally skipped the tesselate spelling but agree we should fix the class names.  One thing that made me skip them was not having time to think about whether we need to preserve the old names.  Are these classes likely to be used by any code outside of Octave?  If not, we can just rename them.  Otherwise, I guess we will need some typedefs or using statements to preserve the old names and allow them to be marked as deprecated before removing them completely.

You can also download a compressed tar snapshot of the development or stable branches directly from the web, if that makes it easier for you to iterate. Unfortunately it looks like the GNU Mercurial server truncates the transfer before the complete tar contents are sent. But you can download from my Git mirror:

• https://gitlab.com/mtmiller/octave/-/archive/default/octave-default.tar.gz
• https://gitlab.com/mtmiller/octave/-/archive/stable/octave-stable.tar.gz

[I was in the process of posting the following message yesterday when my laptop battery ran out of power and I ran out of time.]

I pushed the following changeset on stable and merged with default.

http://hg.savannah.gnu.org/hgweb/octave/rev/2310164737b3

It doesn't fix everything, but I think I got most of them.

There are some more generated files in the list that can be skipped.  But instead of trying to maintain a list of generated files, is there a way for you to work with the mercurial archive instead?  Then you could use "hg locate" to give you a list of all the ultimate source files in the archive.  Everything else is generated from those, so we really should only need to fix problems in those ultimate source files.

Ok, so a new report was generated ignoring now additionally the ChangeLog file (63 error occurrences less) and the overseen "gnulib" directory containing external software (5 error occurrences less).

Hi Kai Torben,

> A handy feature was a patch/diff file, which I can just download apply, and decide to accept your spell fix suggestions.

The request is understandable and I thought about such a Fossies service but since I'm not sure which of the matched words are really spelling errors or typos that could respectively should be corrected Fossies offers only the information (especially variable and class names, URLs, mail addresses and words that directly "touch" some kinds of delimiters or escape  characters may be problematic, some spelling corrections may be ambiguous, some words can be deliberately misspelled and some corrections may have unwanted side effects).

So a vague idea was to make the spelling errors selectable and then to create multiple (or even one) unidiff file(s) but that isn't trivial to realize and for e.g. probably not usable by projects using GitHub.

By the way, the basically used tool "codespell" offers an option "--write-changes" (write changes in place if possible). Together with the option "--interactive 3" (ask for confirmation and ask user to choose one fix when more than one is available) it may be a possible solution (but untested!). To create an appropriate list of words and files to be ignored the mentioned Fossies configuration may be helpful start point.

Thanks for your hint to the false positive that I have "fortunately" overseen. "Fortunately" since you detected a bug on Fossies that was introduced as the line coloring feature for misspelled member files were added (now hopefully fixed).

Using also the hints from Pantxo I have now rerun the check and voilà, now there are 17 error occurrences less ;-)

The html files in doc/interpreter/octave.html/ are all generated from the texinfo sources (.txi and .texi files in doc/interpreter/), so are all .info files. So you can safely eliminate the octave.html directory and *.info files.
The simplest way to eliminate such duplicates is probably to run your spellcheck tool on the tarball, before compilation.

The FOSS server fossies.org - also supporting the latest Octave release - offers a new feature "Source code misspelling reports".

Such reports are normally only generated on request, but as Fossies administrator I have just created (for testing purposes) an analysis for the current development version Octave 5.1.90.

Since development versions are not normally supported by Fossies I have put it in a special "test" folder (that isn't integrated in the Fossies standard services and should - at least principally - also not accessible by search engines):

 https://fossies.org/linux/test/octave-5.1.90.tar.xz/codespell.html

Jens

Although after a first review some obviously wrong matches ("false positives") are already filtered out (ignored) please inform me if you find more of them so that I can force a new improved check if applicable.

Just for information there are also two supplemental pages

 https://fossies.org/linux/test/octave-5.1.90.tar.xz/codespell_conf.html

showing some used "codespell" configurations and

 https://fossies.org/linux/test/octave-5.1.90.tar.xz/codespell_fps.html

showing all resulting obvious "false positives".

And two small remarks:

All files in the directory "OLD-ChangeLogs" were ignored (excluded) since they are containing many spelling errors but are probably no longer interesting for possible spelling corrections (but if so please let me know).

Unsure I was about the word "indicies" at line 263 and 268 of the file libinterp/parse-tree/jit-typeinfo.cc since in the neighborhood in similar constructs also the suggested word "indices" is in use (sorry, I'm a C-layman).