bugGNU Octave - Bugs: bug #57600, [MXE Octave] NSIS installer in...

 
 

bug #57600: [MXE Octave] NSIS installer in blurry on a HiDPI screen

Submitted by:  Markus Mützel <mmuetzel>
Submitted on:  Tue 14 Jan 2020 06:50:47 PM UTC  
 
Category:  Configuration and Build System Severity:  2 - Minor
Priority:  3 - Low Item Group:  Feature Request
Status:  Fixed Assigned to:  John Donoghue <lostbard>
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  Microsoft Windows

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Thu 16 Jan 2020 01:37:54 AM UTC, comment #6: 

Now I am sure that this fix is good.  To replicate Markus issue, even without HiDPI screens, you just need set the display scaling to 125 %, which seems to be done automatically for such screens.

Then I can easily see, that the old installer was blurry, while the installer with the fix of comment #4 looked crystal clear.

Thus I close this issue as fixed and thank you for your help.

Kai Torben Ohlhus <siko1056>
Project Member
Wed 15 Jan 2020 02:46:03 PM UTC, comment #5: 

Thank you John!  Then I start over building all mxe versions again and let's see if there are more complaints before the 5.2.0 release.

Kai Torben Ohlhus <siko1056>
Project Member
Wed 15 Jan 2020 02:34:56 PM UTC, comment #4: 

Perhaps no high enough? Running a 1600 x 1200 screen

I pushed https://hg.octave.org/mxe-octave/rev/225fc4d8f598

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 15 Jan 2020 02:21:40 PM UTC, comment #3: 

Regarding comment #2 John: Do you have a HiDPI screen?

Personally, I did not see a change too.  But my MS Win10 test machine is far from HiDPI.  On the mailing-list (https://lists.gnu.org/archive/html/octave-maintainers/2020-01/msg00166.html) Markus reported, that the following change in MXE had a visible impact:

diff -r 92b6fce85f02 tools/makeinst-script.sh.in
--- a/tools/makeinst-script.sh.in       Mon Jan 13 09:54:00 2020 -0500
+++ b/tools/makeinst-script.sh.in       Wed Jan 15 23:15:48 2020 +0900
@@ -92,6 +92,7 @@
XPStyle on
InstallDir "C:\\Octave\\Octave-\${OCTAVE_VERSION}"
Icon "\${INSTALLER_FILES}/octave-logo.ico"
+ManifestDPIAware true

######################################################################
; StrFunc usage

If you do not see a difference for your devices, then maybe we can just add this option and are on the safe side.

Kai Torben Ohlhus <siko1056>
Project Member
Wed 15 Jan 2020 12:40:10 PM UTC, comment #2: 

I tried adding:

ManifestDPIAware true

and:

ManifestSupportedOS all
ManifestDPIAware true

But dont see any difference on my screen.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Tue 14 Jan 2020 07:39:33 PM UTC, comment #1: 

Looks easy enough to add.

From its docs:

NSIS does not scale the bitmap used by the tree control on the component page and some plugins might have compatibility issues so make sure that you test your installer at different DPI settings if you select true.

So settings it may cause other side effects.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Tue 14 Jan 2020 06:50:47 PM UTC, original submission:  

When installing Octave on Windows, text in the installer windows appears blurry. Compare the text in the title bar of the window with the text inside the window in the attached screenshot.

Setting ManifestDPIAware to true might help:
https://nsis.sourceforge.io/Reference/ManifestDPIAware

According to the documentation that variable was introduced in NSIS v3.0a0. AFAICT, we are using NSIS 3.05. So setting that variable should be possible.

I don't know how and where that variable is set though.
CC'ing John D because he'll probably know better.

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #48229:  Installer_blurry.PNG added by mmuetzel (43KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  • -email is unavailable- added by mmuetzel
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-01-16 siko1056 Severity3 - Normal => 2 - Minor
        Priority5 - Normal => 3 - Low
        StatusReady For Test => Fixed
        Assigned toNone => lostbard
        Open/ClosedOpen => Closed
    2020-01-15 siko1056 StatusNone => Ready For Test
    2020-01-14 mmuetzel Attached File- => Added Installer_blurry.PNG, #48229
        Carbon-Copy- => Added lostbard

    Back to the top


    Powered by Savane 3.5