bugGNU Octave - Bugs: bug #57415, [octave forge] (sockets)...

 
 

bug #57415: [octave forge] (sockets) Compilation fails on Octave 6 because of removed header

Submitted by:  Markus Mützel <mmuetzel>
Submitted on:  Sun 15 Dec 2019 12:47:46 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  John Donoghue <lostbard>
Originator Name:  Open/Closed:  Closed
Release:  other Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Thu 12 Nov 2020 01:12:31 PM UTC, comment #8: 

Fixed in sockets 1.2.1 - closing as fixed

John Donoghue <lostbard>
Project MemberIn charge of this item.
Tue 10 Nov 2020 06:02:42 PM UTC, comment #7: 

new version added to the release tracker after getting an ok from the maintainer

John Donoghue <lostbard>
Project MemberIn charge of this item.
Tue 10 Nov 2020 01:06:45 PM UTC, comment #6: 

I removed the toplevel.h include and it still compiles in windows octave versions ranging from 3.6 - 6.0.92 without error

Pushed:
https://sourceforge.net/p/octave/sockets/ci/ce270907b0264375d9d5bd5f5d9bbc7f10435146/

John Donoghue <lostbard>
Project MemberIn charge of this item.
Mon 09 Nov 2020 01:16:12 PM UTC, comment #5: 

It will probally take a few days before I would get around to adding any patches, maintainer makefile etc anyway.

So I'll send out a email and see what happens over the next few days.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Mon 09 Nov 2020 12:26:22 PM UTC, comment #4: 

@John: I'm not sure if all possibly interested parties are following the bug tracker. To avoid an emotional reaction, maybe you could ask on the mailing list (and write to Paul Dreik directly).
One single day is probably quite short as a dead line for a response though...

Markus Mützel <mmuetzel>
Project Member
Mon 09 Nov 2020 10:01:25 AM UTC, comment #3: 

If you have all necessary permissions, please go ahead with this patch.  If you further can prepare a minor release, I'll approve it tomorrow.

Maybe we can discuss about rules for this case tomorrow.

Kai Torben Ohlhus <siko1056>
Project Member
Sun 08 Nov 2020 02:41:57 PM UTC, comment #2: 

Is the package still being maintained ?  I'm willing to update it if thats ok and if noone will get 'excited' if I do so.

Looking at the log, perhaps the maintainer can be changed to 'Octave Forge community'

John Donoghue <lostbard>
Project MemberIn charge of this item.
Thu 29 Oct 2020 01:00:34 AM UTC, comment #1: 

It also uses error_state which is scheduled to be removed in octave 7.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Sun 15 Dec 2019 12:47:46 PM UTC, original submission:  

Compilation of the Octave forge package sockets fails because the header "toplev.h" was deprecated and finally removed for Octave 6.

A possible fix would be to replace it by "interpreter.h". See e.g. the patch on MXE Octave:
https://hg.octave.org/mxe-octave/file/tip/src/of-sockets-2-deprecated.patch

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  • -email is unavailable- added by mmuetzel
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-11-12 lostbard StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2020-11-10 lostbard StatusNeed Info => Ready For Test
        Assigned toNone => lostbard
    2020-11-09 siko1056 StatusNone => Need Info
    2019-12-15 mmuetzel Carbon-Copy- => Added slask@pauldreik.se

    Back to the top


    Powered by Savane 3.5