bugGNU Octave - Bugs: bug #57386, [octave forge] (nan) Please...

 
 

bug #57386: [octave forge] (nan) Please declare functions with internal linkage as static

Submitted by:  Stefan Brüns <stefanbruens>
Submitted on:  Mon 09 Dec 2019 04:15:55 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 09 Dec 2019 04:15:55 PM UTC, original submission:  

(At least) the following functions are defined with external linkage, although they are just internal helpers:

svmtrain_mex.cpp:
- print_null
- print_string_matlab
- exit_with_help
- do_cross_validation

svmpredict_mex.cpp:
- print_null
- predict
- exit_with_help

Typically, anything but mexFunction should be declared with internal linkage (i.e. either as "static" or within an anonymous namespace (C++ only)).

This allows the compiler to generate better code and avoids exposing internal symbols.

Stefan Brüns <stefanbruens>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by stefanbruens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    No changes have been made to this item

    Back to the top


    Powered by Savane 3.5