bugGNU Octave - Bugs: bug #57309, ode23s removed from odepkg on...

 
 

bug #57309: ode23s removed from odepkg on BitBucket not in core Octave

Submitted by:  CH <atcl>
Submitted on:  Tue 26 Nov 2019 04:24:53 PM UTC  
 
Category:  Octave Function Severity:  1 - Wish
Priority:  3 - Low Item Group:  Matlab Compatibility
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  6.0.90 Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 19 May 2020 08:48:39 AM UTC, comment #9: 

Thank you for the pointer, I made a further commit to address this issue:

https://hg.savannah.gnu.org/hgweb/octave/rev/cf7edf5577c3

Kai Torben Ohlhus <siko1056>
Project Member
Mon 18 May 2020 05:20:53 PM UTC, comment #8: 

Hi,

I agree that was the correct thing to do.
I do expect many compatibility bug reports as soon
as Octave 6 is released, but that will only help
fix ode23s faster.

One thing I would suggest is to change the following in
 _unimplemented_.m :

"Matlab-compatible ODE functions are provided by the odepkg ", ...
"package.  See @url{https://octave.sourceforge.io/odepkg/}.

as the location for odepkg is not correct plus, after removing
ode23s, most matlab compatible solvers are actually in core while
odepkg has mainly some specialized solvers for specific applications.

c.

Carlo de Falco <cdf>
Project Member
Mon 18 May 2020 09:29:05 AM UTC, comment #7: 

I went ahead

https://hg.savannah.gnu.org/hgweb/octave/rev/8085ae13cc4a

Starting with Octave 6 one can make use of this function again.

As ode23s is m-code only and has many BIST, that are all passing now, I assume it is save for a stable release to avoid another year or two of delays.  Any regressions or unmet expectations can be reported in separate bug reports.

Closing this report.

Kai Torben Ohlhus <siko1056>
Project Member
Mon 04 May 2020 02:14:36 PM UTC, comment #6: 

Can someone go ahead and add ode23s to Octave core? That would make it easier to find and troubleshoot any imperfections it might still have.

Nir Krakauer <nir_krakauer>
Fri 06 Dec 2019 07:37:38 AM UTC, comment #5: 

I don't think it is a good idea to make
another release of odepkg that does include
ode23s.

If the purpose of the work you propose is to
make ode23s available again, then you can probably
help with moving it into core?

Carlo de Falco <cdf>
Project Member
Thu 05 Dec 2019 02:44:03 AM UTC, comment #4: 

Thank you for investigating the state of "ode23s".

Thus an interested developer can pick up on moving "ode23s" into Octave core.

In the meantime, I overhauled the wiki page for the "odepkg"

https://wiki.octave.org/Odepkg

but with the current description "ode23s" would not be usable because of

https://bitbucket.org/odepkg/odepkg/commits/17b0e2c5e5f4a11e86e9af20166da6d1beb01ce5?at=octave43

Is it possible to rearrange the Bitbucket repo, such that
 https://bitbucket.org/odepkg/odepkg/commits/17b0e2c5e5f4a11e86e9af20166da6d1beb01ce5?at=octave43

is reverted and "octave43" is merged to "default" and "stable" gets closed?  I think that your repo does not have to offer support for Octave 4.2 any longer.

If you like, I can help out (https://bitbucket.org/account/user/siko1056/).

Kai Torben Ohlhus <siko1056>
Project Member
Wed 04 Dec 2019 04:55:12 PM UTC, comment #3: 

I think I remember what might have happened.

The last release of odepkg was done when we had just
moved ode45 and ode23 from odepkg into core.

ode23s was also expected to be moved to core and so we
didn't want it to be in the package or it would cause
conflcts.

but it was not completely ready so I created a separate branch
from which I produced the release but I left ode23s
on the default branch so that Jacopo, who was working
on it at the time, could complete the adaptation before
moving it to core.

Then Jacopo completed his PhD and found a "real" job
and so things got a bit stuck ...

Anyway, the version of ode23s on the default branch
of the bitbucket repo should be fully functional,
I think if any issues are left to solve they are
related to matlab compatibility and interface consistency
wrt to other solvers.

Carlo de Falco <cdf>
Project Member
Wed 04 Dec 2019 08:46:29 AM UTC, comment #2: 

I'm trying to remember the full story, but ode23s was
not removed (or at least was later re-added) as I still
see it in the BitBucket repo here :

https://bitbucket.org/odepkg/odepkg/src/default/inst/ode23s.m

Carlo de Falco <cdf>
Project Member
Wed 04 Dec 2019 08:07:18 AM UTC, comment #1: 

This is indeed strange.  cdf removed that function from the odepkg on BitBucket back in 2017, but it never arrived in Octave core.  I add cdf to this item to ask him about the state of ode23s.

https://bitbucket.org/odepkg/odepkg/commits/17b0e2c5e5f4a11e86e9af20166da6d1beb01ce5?at=octave43

Kai Torben Ohlhus <siko1056>
Project Member
Tue 26 Nov 2019 04:24:53 PM UTC, original submission:  

The ODE solver "ode23s" is not yet part of core Octave. I would like to ask, if it is planned to move from the odepkg? Given that "ode15s" is available, what is missing for ode23s?

Thank you

CH <atcl>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  • -email is unavailable- added by cdf (Posted a comment)
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by siko1056 (Has more insight about ode23s and the odepkg)
  • -email is unavailable- added by atcl (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-05-19 siko1056 Release5.1.0 => 6.0.90
    2020-05-18 siko1056 CategoryNone => Octave Function
        StatusPostponed => Fixed
        Open/ClosedOpen => Closed
    2019-12-05 siko1056 Severity3 - Normal => 1 - Wish
        Priority5 - Normal => 3 - Low
        StatusNeed Info => Postponed
    2019-12-04 siko1056 StatusNone => Need Info
        Summaryode23s not in core Octave => ode23s removed from odepkg on BitBucket not in core Octave
        Carbon-Copy- => Added cdf

    Back to the top


    Powered by Savane 3.5