bugGNU Octave - Bugs: bug #57269, Size of legend keys for bar graphs...

 
 

bug #57269: Size of legend keys for bar graphs varies with size of labeling text

Submitter:  Rik <rik5>
Submitted:  Tue 19 Nov 2019 04:13:40 PM UTC
   
 
Category:  Plotting Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 27 Nov 2019 01:18:22 AM UTC, comment #6: 

I pushed your patch here https://hg.savannah.gnu.org/hgweb/octave/rev/b3ad1b9417c0.

Closing report.

Rik <rik5>
Group administrator
Tue 26 Nov 2019 02:42:06 PM UTC, comment #5: 

Attached now.

(file #47936)

Pantxo Diribarne <pantxo>
Group Member
Tue 26 Nov 2019 02:41:23 PM UTC, comment #4: 

I attached a patch that makes the icon height 70% of the fontsize in points. Does this look acceptable?

Pantxo Diribarne <pantxo>
Group Member
Tue 19 Nov 2019 10:57:12 PM UTC, comment #3: 

I'm not sure if we need to change the way the code behaves.  It might be worth showing the two pictures on the Maintainer's List and seeing if anyone cares.

Rik <rik5>
Group administrator
Tue 19 Nov 2019 10:54:14 PM UTC, comment #2: 

This is much better.  I still note a difference between previous versions of Octave, Matlab, and the new code.

The new code seems to fix the height of the rectangles whereas the height previously scaled with the "fontsize" property.

For example:


demo barh 2
hl = legend ('a', 'ba', 'c');
## At this point, rectangles are ~10 pixels high on my screen
set (hl, 'fontsize', 30)
## rectangles are still ~10 pixels high, but larger in 5.1 or Matlab



Rik <rik5>
Group administrator
Tue 19 Nov 2019 09:56:43 PM UTC, comment #1: 

I pushed a cset that fixes the issue for me:

http://hg.savannah.gnu.org/hgweb/octave/rev/a0143104b224

Pantxo Diribarne <pantxo>
Group Member
Tue 19 Nov 2019 04:13:40 PM UTC, original submission:  

Code to reproduce:


demo barh 2
legend ('a', 'ba', 'c')


In previous versions of Octave, the rectangular legend keys were all the same size.  With the new legend.m code, the vertical height of the rectangles is dependendent on the text that is next to them

file barh_tall_key.png

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #47936:  bug57269.patch added by pantxo (966B - text/x-patch)
file #47898:  barh_tall_key.png added by rik5 (13KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  • -email is unavailable- added by rik5
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-11-27 rik5 StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2019-11-26 pantxo Attached File- Added bug57269.patch, #47936
    2019-11-26 pantxo StatusPatch Reviewed Patch Submitted
    2019-11-19 rik5 StatusReady For Test Patch Reviewed
    2019-11-19 pantxo StatusConfirmed Ready For Test
    2019-11-19 rik5 Attached File- Added barh_tall_key.png, #47898
        Carbon-Copy- Added pantxo

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code