bugGNU Octave - Bugs: bug #56996, [octave forge] (linear-algebra)...

 
 

bug #56996: [octave forge] (linear-algebra) Build failure with Octave 5.1.0

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Sat 05 Oct 2019 11:13:14 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 5.1.0 Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 14 Nov 2019 07:45:10 PM UTC, comment #10: 

Fixed with the new linear-algebra 2.2.3 release.

Nir Krakauer <nir_krakauer>
Fri 01 Nov 2019 07:43:32 PM UTC, comment #9: 

Thanks.
What would now be the minimum octave release that linear-algebra works with?

BTW there's more about a linear-algebra-2.2.3 release here:
https://savannah.gnu.org/patch/index.php?9646

Philip Nienhuis <philipnienhuis>
Group Member
Fri 01 Nov 2019 05:34:14 PM UTC, comment #8: 

OK, I removed gsvd and pgmres from the package repository.

Nir Krakauer <nir_krakauer>
Thu 17 Oct 2019 09:20:37 PM UTC, comment #7: 

Reading up on pgmres in the linear-algebra func reference [1] and comparing with the output of "help gmres" in Octave I'd say yes. gmres in core seems to offer more options as well.
But I've never used either function so take this with a grain of salt.

[1] https://octave.sourceforge.io/linear-algebra/function/pgmres.html

Philip Nienhuis <philipnienhuis>
Group Member
Wed 16 Oct 2019 06:32:09 PM UTC, comment #6: 

Besides gsvd, the only other compiled function in linear-algebra is pgmres. Is its functionality completely superseded by gmres in core Octave?

Nir Krakauer <nir_krakauer>
Wed 16 Oct 2019 05:52:22 PM UTC, comment #5: 

AFAICS all binary modules can go, as I think they all duplicate functions in core Octave (not necessarily with the same name).

Philip Nienhuis <philipnienhuis>
Group Member
Tue 15 Oct 2019 08:39:49 PM UTC, comment #4: 

Should we just remove all GSVD code from linear-algebra, since it's been part of core Octave since 4.4?

Nir Krakauer <nir_krakauer>
Fri 11 Oct 2019 01:08:24 PM UTC, comment #3: 

It was last released 3/6/2015, although there has been some commits to the repo since then.

So it probally just waiting on someone to work on it

John Donoghue <lostbard>
Group Member
Fri 11 Oct 2019 09:49:46 AM UTC, comment #2: 

Isn't it time to just drop all binary modules from linear-algebra? They have all been moved to core Octave AFAIK.

In my own mxe-octave builds I include a weeded out of linear-algebra w/o those modules since several years.

Philip Nienhuis <philipnienhuis>
Group Member
Sat 05 Oct 2019 11:15:10 AM UTC, comment #1: 

The title of this bug report went wrong.  It should read, instead:

"[octave forge] (linear-algebra) Build failure with Octave 5.1.0"

Please, change it, if possible.

Rafael Laboissière <rlaboiss>
Sat 05 Oct 2019 11:13:14 AM UTC, original submission:  

The linear-algebra package fails to compile against Octave 5.1.0:


g++ -c -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/octave-5.1.0/octave/.. -I/usr/include/octave-5.1.0/octave  -pthread -fopenmp -g -O2 -fdebug-prefix-map=/var/data/rlaboiss/debian/PKGS/octave-linear-alg
ebra/octave-linear-algebra=. -fstack-protector-strong -Wformat -Werror=format-security    gsvd.cc -o /tmp/oct-T9OoI2.o
gsvd.cc:26:10: fatal error: gripes.h: No such file or directory
   26 | #include "gripes.h"
      |          ^~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:12: gsvd.oct] Error 1


The patch attached to this bug report fixes the problem.

Rafael Laboissière <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by i7tiol (Updated the item)
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-11-16 i7tiol StatusNeed Info Fixed
        Open/ClosedOpen Closed
    2019-10-11 philipnienhuis StatusNone Need Info
    2019-10-06 siko1056 Releaseother 5.1.0
        Summary[octave forge] (linear-algebra) Compilation issues with gcc 9 [octave forge] (linear-algebra) Build failure with Octave 5.1.0
    2019-10-05 rlaboiss Attached File- Added errwarn-instead-of-gripes.patch, #47616

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code