bugGNU Octave - Bugs: bug #55952, build fails with texinfo error...

 
 

bug #55952: build fails with texinfo error "Macro name seealso already defined"

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Mon 18 Mar 2019 11:25:18 PM UTC  
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Thu 21 Mar 2019 09:01:18 PM UTC, comment #11: 

This also works for me now with @seealso in a pkg function. Have not tested generate_html yet, but can follow up in the unlikely event there is a problem there.

Thank you for the quick solution to this not-even-released-yet change to texinfo.

Mike Miller <mtmiller>
Project Administrator
Tue 19 Mar 2019 08:33:54 PM UTC, comment #10: 

This works for me now. I think the substitution in the '__makeinfo__' function should take care of Forge packages and the 'generate_html' package too.

We could still look at adopting texinfo's @seealso, someday, maybe 5 years from now when everyone has texinfo 7 or greater and it's widely available.

Mike Miller <mtmiller>
Project Administrator
Tue 19 Mar 2019 05:55:55 PM UTC, comment #9: 

A fresh build seems to clear up the "sealso" problem.
I still get

warning: onCleanup: error caught while executing cleanup function:
pkg: cannot create file /usr/local/share/octave/octave_packages

but that seems to be a separate problem.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Tue 19 Mar 2019 05:26:10 PM UTC, comment #8: 

Now I see :


octave:2> cd ../test/pkg/
octave:3> test pkg.tst
/tmp/octave-help-oKulMZ:129: unknown command `seealso'
/tmp/octave-help-oKulMZ:129: misplaced {
/tmp/octave-help-oKulMZ:129: misplaced }
/tmp/octave-help-OaPZAj:128: unknown command `seealso'
/tmp/octave-help-OaPZAj:128: misplaced {
/tmp/octave-help-OaPZAj:128: misplaced }
/tmp/octave-help-EHqmKE:129: unknown command `seealso'
/tmp/octave-help-EHqmKE:129: misplaced {
/tmp/octave-help-EHqmKE:129: misplaced }
/tmp/octave-help-YSLqI0:128: unknown command `seealso'
/tmp/octave-help-YSLqI0:128: misplaced {
/tmp/octave-help-YSLqI0:128: misplaced }
/tmp/octave-help-ml6m5n:129: unknown command `seealso'
/tmp/octave-help-ml6m5n:129: misplaced {
/tmp/octave-help-ml6m5n:129: misplaced }
/tmp/octave-help-5klVhM:128: unknown command `seealso'
/tmp/octave-help-5klVhM:128: misplaced {
/tmp/octave-help-5klVhM:128: misplaced }
/tmp/octave-help-iHndNb:129: unknown command `seealso'
/tmp/octave-help-iHndNb:129: misplaced {
/tmp/octave-help-iHndNb:129: misplaced }
/tmp/octave-help-qvpZ8B:128: unknown command `seealso'
/tmp/octave-help-qvpZ8B:128: misplaced {
/tmp/octave-help-qvpZ8B:128: misplaced }
/tmp/octave-help-ozlfT3:129: unknown command `seealso'
/tmp/octave-help-ozlfT3:129: misplaced {
/tmp/octave-help-ozlfT3:129: misplaced }
/tmp/octave-help-vD04rw:128: unknown command `seealso'
/tmp/octave-help-vD04rw:128: misplaced {
/tmp/octave-help-vD04rw:128: misplaced }
/tmp/octave-help-2cbPn0:129: unknown command `seealso'
/tmp/octave-help-2cbPn0:129: misplaced {
/tmp/octave-help-2cbPn0:129: misplaced }
/tmp/octave-help-XwKdav:128: unknown command `seealso'
/tmp/octave-help-XwKdav:128: misplaced {
/tmp/octave-help-XwKdav:128: misplaced }
/tmp/octave-help-GzlMn1:129: unknown command `seealso'
/tmp/octave-help-GzlMn1:129: misplaced {
/tmp/octave-help-GzlMn1:129: misplaced }
/tmp/octave-help-H5mNqy:128: unknown command `seealso'
/tmp/octave-help-H5mNqy:128: misplaced {
/tmp/octave-help-H5mNqy:128: misplaced }
PASSES 11 out of 11 tests
warning: onCleanup: error caught while executing cleanup function:
pkg: cannot create file /usr/local/share/octave/octave_packages

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Tue 19 Mar 2019 05:11:49 PM UTC, comment #7: 
John W. Eaton <jwe>
Project Administrator
Tue 19 Mar 2019 04:53:42 PM UTC, comment #6: 

I pushed a changeset for makeinfo to fix @seealso in help output:

http://hg.savannah.gnu.org/hgweb/octave/rev/ca5344dd5f1c

John W. Eaton <jwe>
Project Administrator
Tue 19 Mar 2019 04:46:31 PM UTC, comment #5: 

I see.  For help, we can also translate @seealso in any text we send to makeinfo.  Would that be enough?

John W. Eaton <jwe>
Project Administrator
Tue 19 Mar 2019 04:19:39 PM UTC, comment #4: 

That solves the build for the user manual, but it really breaks 'help', and it will break Forge packages, both 'help' and the HTML docs built from doc strings.

I think we have a little bit of time to get this right, because nothing has been released yet. We could talk with texinfo upstream about this, or we could even try using the new @seealso and see how it compares with ours.

Mike Miller <mtmiller>
Project Administrator
Tue 19 Mar 2019 02:48:42 PM UTC, comment #3: 

I pushed the following changeset to default:

http://hg.savannah.gnu.org/hgweb/octave/rev/6acb713f8231

Does it fix the problem for you?  If so, do you think we should also apply it on stable?

John W. Eaton <jwe>
Project Administrator
Mon 18 Mar 2019 11:46:43 PM UTC, comment #2: 

Ah, here it is in upstream texinfo

https://git.savannah.gnu.org/cgit/texinfo.git/commit/?id=aa18f519e091b6ada0fb2b0a65a51880031d5014

So yeah, texinfo just added an experimental new '@seealso' command, Octave will need to adapt to this on the default branch for when the next texinfo after 6.6 comes down the line.

Mike Miller <mtmiller>
Project Administrator
Mon 18 Mar 2019 11:37:45 PM UTC, comment #1: 

Yeah, this is due to a new texinfo.tex file from gnulib. I follow gnulib's master branch when I build default, instead of using our gnulib subrepository.

This gnulib change

https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=b451121ab45497e78cb6f612c8673a9705193391

Adds a 'seealso' macro to texinfo.tex, which breaks Octave's own private 'seealso'.

I'm not actually sure where the upstream for gnulib's copy of texinfo.tex is, because what I get from gnulib now is different from the one in the GNU texinfo git repository.

This may end up not being an issue, but may be something we have to deal with when we next update gnulib.

Mike Miller <mtmiller>
Project Administrator
Mon 18 Mar 2019 11:25:18 PM UTC, original submission:  

My recent builds are failing at doc/interpreter/octave.dvi with

TEXINPUTS="../build-aux:$TEXINPUTS" \
MAKEINFO='/bin/bash /home/mike/src/octave/default/build-aux/missing makeinfo   -I doc/interpreter -I ../doc/interpreter' \
texi2dvi  --build-dir=doc/interpreter/octave.t2d -o doc/interpreter/octave.dvi  \
`test -f 'doc/interpreter/octave.texi' || echo '/home/mike/src/octave/default/+build-default/../'`doc/interpreter/octave.texi
This is pdfTeX, Version 3.14159265-2.6-1.40.19 (TeX Live 2019/dev/Debian) (preloaded format=etex)
restricted \write18 enabled.
entering extended mode
(/home/mike/src/octave/default/+build-default/../doc/interpreter/octave.texi
(/home/mike/src/octave/default/build-aux/texinfo.tex
Loading texinfo [version 2019-03-16.20]: pdf, fonts, markup, glyphs,
page headings, tables, conditionals, indexing, sectioning, toc, environments,
defuns, macros, cross references, insertions,
(/usr/share/texlive/texmf-dist/tex/generic/epsf/epsf.tex
This is `epsf.tex' v2.7.4 <14 February 2011>
) localization, formatting, and turning on texinfo input format.)
(/home/mike/src/octave/default/+build-default/../doc/interpreter/macros.texi
/home/mike/src/octave/default/+build-default/../doc/interpreter/macros.texi:51:
Macro name seealso already defined.
@macroxxx ...@the @macname @space already defined}
                                                  @fi @global @cslet {macsav...
l.51 @macro seealso {args}

?

The relevant error message in that mess of output is "Macro name seealso already defined" (I think).

The entire build was done with 'make -j1', so no parallelism problem.

This bug only started appearing in my builds today, possibly due to distro updates over the weekend. Possibly due to gnulib updates?

Marking as confirmed since @haawda originally reported this on bug #55225.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mtmiller
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-21 mtmiller StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2019-03-19 jwe StatusConfirmed => Ready For Test
    2019-03-18 mtmiller Carbon-CopyRemoved 80942 => -
    2019-03-18 mtmiller Carbon-Copy- => Added haawda

    Back to the top


    Powered by Savane 3.5