GNU Octave - Bugs: bug #55836, 1024x1024 app icon

Group

Main
- Main
- View members
- Search
Homepage
Download
Mailing lists
Source code
Bugs
- Submit new
- Browse
- Reset to open
- Digest
- Dependencies
- ~~Export~~
- Get statistics
- Search
Tasks
- ~~Submit new~~
- Browse
- Reset to open
- Digest
- Dependencies
- ~~Export~~
- Get statistics
- Search
Patches
- Submit new
- Browse
- Reset to open
- Digest
- Dependencies
- ~~Export~~
- Get statistics
- Search

bug #55836: 1024x1024 app icon

Submitter:	Andrew Janke <apjanke>
Submitted:	Tue 05 Mar 2019 05:26:21 PM UTC


Category:	GUI	Severity:	1 - Wish
Priority:	3 - Low	Item Group:	Feature Request
Status:	Fixed	Assigned to:	None
Originator Name:		Open/Closed: *	Closed
Release: *	dev	Operating System: *	Any
Fixed Release:	None	Planned Release:	None

* Mandatory Fields

Add a New Comment Rich Markup

Jump to the original submission

Tue 13 Aug 2019 11:34:12 PM UTC, comment #13: The builders on Flathub are fine. Happily closing this report again.	Kai Torben Ohlhus <siko1056>
Tue 13 Aug 2019 09:21:54 PM UTC, comment #12: comment #10: > Kai, another option would be to add a post-install to the flatpak build to delete the 1024 icon directory, right? Mike, comment #10 and comment #11 do the trick for me. Thanks for the pointer! cleanup: - /share/icons/hicolor/1024x1024 Lovely, this is for me the best solution: Not touching Octave at all or making it unnecessarily more ugly by adding configure options :D I wait for the builders on GitHub to finish and close this report and the Test PR on GitHub.	Kai Torben Ohlhus <siko1056>
Tue 13 Aug 2019 06:28:16 PM UTC, comment #11: There are some Debian packages in the archive that ship 1024x1024 icon files, for example connectagram, hexalate, owncloud-client, and scribus. I'm not convinced that forbidding 1024 icons is a good thing, I think a workaround just for the flatpak build might be fine.	Mike Miller <mtmiller>
Tue 13 Aug 2019 06:24:12 PM UTC, comment #10: Thanks, understood now. The error comes from flatpak-validate-icon, because the 'flatpak build-export' subcommand calls it with arguments '512 512' as the maximum width and height. That's unfortunate. Kai, another option would be to add a post-install to the flatpak build to delete the 1024 icon directory, right?	Mike Miller <mtmiller>
Tue 13 Aug 2019 04:07:06 PM UTC, comment #9: So far I only built on my own machine with Flatpak 1.2.3 on openSUSE. I try to reproduce this more public on your GitHub repo: https://github.com/flathub/org.octave.Octave/pull/75	Kai Torben Ohlhus <siko1056>
Tue 13 Aug 2019 03:21:36 PM UTC, comment #8: Kai, this is interesting. Do you have an example build failure from the flatpak build tools? What if we make the list of icon sizes a configurable option in the configure script?	Mike Miller <mtmiller>
Tue 13 Aug 2019 09:13:57 AM UTC, comment #7: This is a minor cosmetic issue. No harm in postponing or reverting it.	Andrew Janke <apjanke>
Tue 13 Aug 2019 08:38:20 AM UTC, comment #6: Unfortunately, this simple extension has negative impact on flatpak builds, I tried recently. The flatpak developers are reluctant to increase the value above 512x512 [1] and refer to [2]. Personally I don't understand this reluctance and issue, but this makes building flatpaks of the current stable branch impossible, which are quite important to me. Maybe we need a branch for macOS builds here. If it is a minor cosmetic issue for macOS, can we postpone this changeset until those developers run Linux systems with Retina displays ;-) [1] https://github.com/flatpak/flatpak/pull/2696 [2] https://lwn.net/Articles/794075/	Kai Torben Ohlhus <siko1056>
Wed 06 Mar 2019 01:15:43 AM UTC, comment #5: Looks good to me! Sorry for not being able to properly format the commit metadata myself; I just don't have enough experience with this system yet. Thanks for pulling this in quickly.	Andrew Janke <apjanke>
Wed 06 Mar 2019 01:03:47 AM UTC, comment #4: I added this bug number and a proper body to the commit message (please refer to https://wiki.octave.org/Commit_message_guidelines) and pushed on the stable branch https://hg.savannah.gnu.org/hgweb/octave/rev/11e7037bed01 I also tested make, make install, and make dist, and the icon shows up in the expected places. Thank you for your fix!	Mike Miller <mtmiller>
Tue 05 Mar 2019 07:47:25 PM UTC, comment #3: Yep, that worked. Added a “1024” line, and the 1024x1024 octave.png appeared in the installation. Patch: file #46433	Andrew Janke <apjanke>
Tue 05 Mar 2019 05:36:52 PM UTC, comment #2: I see it. Testing now.	Andrew Janke <apjanke>
Tue 05 Mar 2019 05:32:25 PM UTC, comment #1: Yeah, I think that would be a one-line change to etc/module.mk, can you test that?	Mike Miller <mtmiller>
Tue 05 Mar 2019 05:26:21 PM UTC, original submission: The octave installation has several icons in share/icons/hicolor/MxN directories. Newer versions of macOS for Retina Macs can make use of 1024x1024 icons now. Could a 1024x1024 icon be added to the icon set there? Minor cosmetic issue.	Andrew Janke <apjanke>

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:


Comment:

Attached Files

file #46433: app-icon-1024x1024.patch added by apjanke (679B - application/octet-stream)

Depends on the following items: None found

Items that depend on this one: None found

Carbon-Copy List

-email is unavailable- added by siko1056 (Posted a comment)

-email is unavailable- added by apjanke (Submitted the item)

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only group members can vote.

Please enter the title of George Orwell's famous dystopian book (it's a date):

Follow 11 latest changes.

Date	Changed by	Updated Field	Previous Value	Replaced by
2019-08-13	siko1056	Status	Works For Me	Fixed
		Open/Closed	Open	Closed
2019-08-13	siko1056	Status	None	Works For Me
2019-08-13	siko1056	Status	Fixed	None
		Open/Closed	Closed	Open
2019-03-06	mtmiller	Status	Confirmed	Fixed
		Open/Closed	Open	Closed
2019-03-05	apjanke	Attached File	-	Added app-icon-1024x1024.patch, #46433
2019-03-05	mtmiller	Severity	3 - Normal	1 - Wish
		Priority	5 - Normal	3 - Low
		Status	None	Confirmed

GNU Octave - Bugs: bug #55836, 1024x1024 app icon

bug #55836: 1024x1024 app icon

<a href="#postcomment">Post a Comment</a>

<a href="#discussion">Discussion</a>

<a href="#attached">Attached Files</a>

<a href="#dependencies">Dependencies</a>

<a href="#cc">Mail Notification Carbon-Copy List</a>

<a href="#votes">Votes</a>

<a href="#history">History</a>