bugGNU Octave - Bugs: bug #55788, pkg install no longer supports...

 
 

bug #55788: pkg install no longer supports .zip archives

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Wed 27 Feb 2019 12:48:53 AM UTC  
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  5.1.0 Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 04 Mar 2019 03:21:05 AM UTC, comment #3: 

Thanks!  In case Symbolic users find their way here after trying to install the symbolic-win-py-bundle-2.7.1.zip file, I've posted a symbolic-win-py-bundle-2.7.1.tar.gz alternative at https://github.com/cbm755/octsympy/releases

Colin Macdonald <cbm>
Fri 01 Mar 2019 04:43:05 AM UTC, comment #2: 

Fixed on the stable branch

This will be part of Octave 5.2.

Mike Miller <mtmiller>
Project Administrator
Wed 27 Feb 2019 06:12:18 AM UTC, comment #1: 

@Mike: I'm fine with either approach that you suggested.

Rik <rik5>
Project Administrator
Wed 27 Feb 2019 12:48:53 AM UTC, original submission:  

In Octave 4.4 and older, "pkg install foo.zip" worked.

This is related to bug #54657 and https://hg.savannah.gnu.org/hgweb/octave/rev/75ed70a1c108 fixing the 'unpack' function. I think that bug fix is entirely accurate, but it did not account for this regression in the 'pkg' function.

The 'pkg' subfunction 'install.m' uses the 'untar' function, regardless of the input file. This used to work even on .zip files, which is weird, but that is the cause of this regression.

Possible appropriate fixes:

  • change 'untar' to 'unpack' and let it always use file extension
  • add if-else to call 'unzip' or 'untar' depending on file extension

The second may be better and is definitely less risky, only use 'unzip' if the file ends with '.zip', always fall back to 'untar' to work the way the function used to. It also consistently uses Matlab compatible functions 'untar' and 'unzip', 'unpack' is Octave specific.

Originally reported at https://lists.gnu.org/archive/html/octave-maintainers/2019-02/msg00198.html.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by cbm (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by cbm
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-01 mtmiller StatusConfirmed => Fixed
        Open/ClosedOpen => Closed
    2019-02-27 cbm Carbon-Copy- => Added cbm
    2019-02-27 mtmiller Carbon-CopyRemoved 80942 => -

    Back to the top


    Powered by Savane 3.5