bugGNU Octave - Bugs: bug #55558, inaccurate error message when...

 
 

bug #55558: inaccurate error message when gnuplot binary is broken or wrong

Submitter:  Mike Miller <mtmiller>
Submitted:  Wed 23 Jan 2019 06:50:49 PM UTC
   
 
Category:  Plotting with gnuplot Severity:  1 - Wish
Priority:  3 - Low Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 31 Jan 2019 09:42:53 PM UTC, comment #7: 

Done (https://hg.savannah.gnu.org/hgweb/octave/rev/c88871c44c56).

Marking as fixed and closing report.

Rik <rik5>
Group administrator
Thu 31 Jan 2019 07:06:58 PM UTC, comment #6: 

This is a low priority, not urgent, I vote for default.

Mike Miller <mtmiller>
Group Member
Thu 31 Jan 2019 04:01:43 PM UTC, comment #5: 

I'll push it later today.  Stable or default?

Rik <rik5>
Group administrator
Thu 31 Jan 2019 07:47:35 AM UTC, comment #4: 

Looks good and works for me with some limited testing. Tested with a good gnuplot program, an intentionally wrong one, and an older one that had missing library dependencies and this does the right thing.

Mike Miller <mtmiller>
Group Member
Wed 30 Jan 2019 09:03:00 PM UTC, comment #3: 

@Mike: Do you have a chance to review the attached patch?

Rik <rik5>
Group administrator
Mon 28 Jan 2019 05:55:11 AM UTC, comment #2: 

Attached is a patch which I think does the correct thing.

(file #46113)

Rik <rik5>
Group administrator
Thu 24 Jan 2019 05:55:08 PM UTC, comment #1: 

Yes, this is true.  It hasn't been a high priority since the focus has been on the qt toolkit.  Marking as confirmed.

Rik <rik5>
Group administrator
Wed 23 Jan 2019 06:50:49 PM UTC, original submission:  

As originally reported in bug #55528, if the gnuplot binary that Octave is trying to use is either not a valid binary, or the wrong program, or fails in some other way, a misleading error says that gnuplot is too old.

This is easy to demonstrate by simply pointing 'gnuplot_binary' to something else:


>> gnuplot_binary ('/bin/false');
>> graphics_toolkit gnuplot
error: graphics_toolkit: gnuplot version too old.
error: called from
    graphics_toolkit at line 88 column 9


There should be an improved error check that reports that something went wrong calling the gnuplot program.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46113:  bug55558.cset added by rik5 (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-01-31 rik5 StatusPatch Reviewed Fixed
        Open/ClosedOpen Closed
    2019-01-31 mtmiller StatusPatch Submitted Patch Reviewed
    2019-01-28 rik5 Attached File- Added bug55558.cset, #46113
        StatusConfirmed Patch Submitted
    2019-01-24 rik5 StatusNone Confirmed
    2019-01-23 mtmiller Priority5 - Normal 3 - Low
    2019-01-23 mtmiller Carbon-CopyRemoved 80942 -

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code