bugGNU Octave - Bugs: bug #55241, movmax should call movfun instead...

 
 

bug #55241: movmax should call movfun instead of movmax

Submitter:  A.R. Burgers <arb>
Submitted:  Wed 19 Dec 2018 09:00:09 AM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  juanpi
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 19 Dec 2018 01:17:35 PM UTC, comment #2: 

Hi,

I have fixed these bugs in all the functions and added a simple test to each one. See  https://hg.savannah.gnu.org/hgweb/octave/rev/895f2f609a96

Closing the report

Juan Pablo Carbajal <juanpi>
Group Member
Wed 19 Dec 2018 11:11:02 AM UTC, comment #1: 

This seems to be a problme with all the files ported to Octave, the orginal source[1] do not have these bugs

[1]: https://bitbucket.org/KaKiLa/movfun/src/default/inst/movmax.m

Juan Pablo Carbajal <juanpi>
Group Member
Wed 19 Dec 2018 09:00:09 AM UTC, original submission:  

movmax(rand(10,1), 3) errors out:


octave:3> movmax(rand(10,1),3)
error: movmax: invalid input at position 1
error: called from
    __parse_movargs__ at line 54 column 7
    movmax at line 130 column 5
stopped in ../octave/scripts/signal/__parse_movargs__.m at line 54


guess movmax should call movfun instead of itself? With that it change it works.


diff -r 01f1e70c80b6 scripts/statistics/movmax.m
--- a/scripts/statistics/movmax.m       Tue Dec 18 22:24:37 2018 -0800
+++ b/scripts/statistics/movmax.m       Wed Dec 19 09:53:03 2018 +0100
@@ -127,7 +127,7 @@
     print_usage ();
   endif

-  y = movmax (@max, x, wlen, __parse_movargs__ ("movmax", varargin{:}){:});
+  y = movfun (@max, x, wlen, __parse_movargs__ ("movmax", varargin{:}){:});

 endfunction


A.R. Burgers <arb>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by juanpi (Posted a comment)
  • -email is unavailable- added by arb (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-12-19 juanpi StatusNone Fixed
        Open/ClosedOpen Closed
    2018-12-19 juanpi Assigned toNone juanpi

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code