bugGNU Octave - Bugs: bug #55234, compile error in...

 
 

bug #55234: compile error in libgui/src/documentation.cc

Submitted by:  A.R. Burgers <arb>
Submitted on:  Sun 16 Dec 2018 07:40:48 PM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 17 Dec 2018 03:43:27 PM UTC, comment #8: 

Thanks a lot!

Torsten Lilge <ttl>
Project Member
Mon 17 Dec 2018 03:43:22 PM UTC, comment #7: 

Thanks. Closing report.

Pantxo Diribarne <pantxo>
Project Member
Mon 17 Dec 2018 03:40:28 PM UTC, comment #6: 

Fixed mine as well. Checked the test cases as well.

Sahil <batterylow>
Mon 17 Dec 2018 02:48:03 PM UTC, comment #5: 

yes, fixes the compile for me with 5.4

A.R. Burgers <arb>
Mon 17 Dec 2018 02:45:49 PM UTC, comment #4: 

@Torsten: Done here

http://hg.savannah.gnu.org/hgweb/octave/rev/e603f555e2d7

Can someone confirm that it fixes the issue (including with Qt 4.8)?

Pantxo Diribarne <pantxo>
Project Member
Mon 17 Dec 2018 02:33:23 PM UTC, comment #3: 

Sorry, this was introduced by me. Unfortunately, I can not fix this before tonight (CET). Pantxo, could you push the patch presented in comment #1?

Torsten Lilge <ttl>
Project Member
Mon 17 Dec 2018 02:26:16 PM UTC, comment #2: 

Greetings!

I too get the same error when trying to build octave, using Qt 4.8.7 and Linux Mint 19 (Tara).

  CXX      libgui/src/m-editor/libgui_src_libgui_src_la-find-dialog.lo
In file included from /usr/include/qt4/QtHelp/QHelpSearchEngine:1:0,
                 from ../octave/./libgui/src/documentation.cc:39:
/usr/include/qt4/QtHelp/qhelpsearchengine.h: In constructor ‘QHelpSearchQuery::QHelpSearchQuery(QHelpSearchQuery::FieldName, const QStringList&)’:
/usr/include/qt4/QtHelp/qhelpsearchengine.h:72:9: warning: declaration of ‘wordList’ shadows a member of ‘QHelpSearchQuery’ [-Wshadow]
         : fieldName(field), wordList(wordList) {}
         ^
/usr/include/qt4/QtHelp/qhelpsearchengine.h:75:17: note: shadowed declaration is here
     QStringList wordList;
                 ^~~~~~~~
../octave/./libgui/src/documentation.cc: In member function ‘void octave::documentation::global_search()’:
../octave/./libgui/src/documentation.cc:399:51: error: no match for call to ‘(QStringList) ()’
       m_query_string = queries.first ().wordList ().first ();
                                                   ^
  CXX      libgui/src/m-editor/libgui_src_libgui_src_la-octave-qscintilla.lo
Makefile:16592: recipe for target 'libgui/src/libgui_src_libgui_src_la-documentation.lo' failed
make[2]: *** [libgui/src/libgui_src_libgui_src_la-documentation.lo] Error 1

Sahil <batterylow>
Mon 17 Dec 2018 02:11:11 PM UTC, comment #1: 

I observe the same build failure with Qt 5.7. The following change make the build complete fine:

diff -r 05ec27d632da libgui/src/documentation.cc
--- a/libgui/src/documentation.cc        Sun Dec 16 23:46:53 2018 -0800
+++ b/libgui/src/documentation.cc        Mon Dec 17 15:01:13 2018 +0100
@@ -396,7 +396,7 @@
     QList<QHelpSearchQuery> queries
       = m_help_engine->searchEngine ()->queryWidget ()->query ();
     if (queries.count ())
-      m_query_string = queries.first ().wordList ().first ();
+      m_query_string = queries.first ().wordList.first ();
     else
       m_query_string = "";
#endif

i.e. "wordList" is a public data member, not a method, see http://doc.qt.io/qt-5/qhelpsearchquery.html#wordList-var.

Pantxo Diribarne <pantxo>
Project Member
Sun 16 Dec 2018 07:40:48 PM UTC, original submission:  

a build failure in recent dev and Qt 5.4:

  CXX      libgui/src/libgui_src_libgui_src_la-documentation.lo
../octave/libgui/src/documentation.cc: In member function 'void octave::documentation::global_search()':
../octave/libgui/src/documentation.cc:399:51: error: no match for call to '(QStringList) ()'
       m_query_string = queries.first ().wordList ().first ();
                                                   ^
make[2]: *** [libgui/src/libgui_src_libgui_src_la-documentation.lo] Error 1
make[2]: Leaving directory `/scratch/aburgers/octave/x86_64'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/scratch/aburgers/octave/x86_64'
make: *** [all] Error 2

cat HG-ID
af99ea9c325f+

A.R. Burgers <arb>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by batterylow (Posted a comment)
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by arb (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-12-17 pantxo StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2018-12-17 ttl StatusFixed => Ready For Test
        Open/ClosedClosed => Open
    2018-12-17 pantxo StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2018-12-17 pantxo StatusNone => Ready For Test

    Back to the top


    Powered by Savane 3.5