bugGNU Octave - Bugs: bug #55228, Doc browser: Go to occurrence of...

 
 

bug #55228: Doc browser: Go to occurrence of search text when clicking a search result

Submitted by:  Torsten Lilge <ttl>
Submitted on:  Sat 15 Dec 2018 07:36:55 AM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  Torsten Lilge <ttl>
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sat 29 Dec 2018 02:48:09 PM UTC, comment #8: 

Thanks Torsten, I can't test this change right now but it looks like it will do what I expect.

Pantxo Diribarne <pantxo>
Project Member
Sat 29 Dec 2018 12:25:39 PM UTC, comment #7: 

With changeset http://hg.savannah.gnu.org/hgweb/octave/rev/e1b849489e73 the full text search in the opened help text is based on the first quoted string within the search query string or on the first non-quoted string.

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Wed 26 Dec 2018 08:56:22 PM UTC, comment #6: 

As a result of this change, compound search queries are not handled very well now.

Trying to search for e.g. "figure properties" (including quotes) from the Search tab lead to a few results. Clicking the first one, which is also the most relevant here since its title is "Figure Properties", opens the corresponding page, but at the first occurrence of "figure (including the first quote).
In this case I would expect the page to be open at the first line since the title exactly matches the search query.

Note that running "doc 'figure properties'" from the terminal, automatically opens the right html page, at the first line. Maybe part of the code for this could be reused for that. 

Pantxo Diribarne <pantxo>
Project Member
Mon 17 Dec 2018 09:32:05 PM UTC, comment #5: 

With changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/3f46b474d2bb
the first text occurrence is now shown in the first visible line.

Closing the report.

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Mon 17 Dec 2018 07:03:46 PM UTC, comment #4: 

Yes, the blue colored links.
Again, that issue is no big deal.

Philip Nienhuis <philipnienhuis>
Project Member
Sun 16 Dec 2018 09:39:01 PM UTC, comment #3: 

Philip, with "title of the search result" you mean the blue colored link? This is the only part of the search result which is clickable. The contents of the result widget in the search pane is created and formatted by the help-engine of Qt, not by our code.

I can confirm the other issue and will try to fix this.

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Sun 16 Dec 2018 08:24:10 PM UTC, comment #2: 

Thanks Torsten for making this.

It now works, but in an -at first- somewhat unexpected way.
One has to click the title of the search results rather than the search text below the title; OK, I can very well live with that.

Another small thing:
When clicking a function name in the function index, the text displayed has the first occurrence on the top line (see attached pic "bug_55228_Linux_viaFuncIndex.png").
When clicking a function name through the search function, the text  displayed has the search term at the bottom line (see attached pic "bug_55228_Linux_viaSearch.png").
IMO it would be better if the search text would be shown at the top line.


Philip Nienhuis <philipnienhuis>
Project Member
Sun 16 Dec 2018 10:45:40 AM UTC, comment #1: 

With changeset http://hg.savannah.gnu.org/hgweb/octave/rev/af99ea9c325f clicking a link in the search result widget opens the linked help section, highlights all occurrences of the search text in it and goes to the first occurrence.

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Sat 15 Dec 2018 07:36:55 AM UTC, original submission:  

Clicking on a result in the search pane, the text browser jumps to the beginning of the related chapter but not to the occurrence of the search text.

Torsten Lilge <ttl>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by ttl (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-12-17 ttl StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2018-12-16 philipnienhuis Attached File- => Added bug_55228_Linux_viaFuncIndex.png, #45676
        Attached File- => Added bug_55228_Linux_viaSearch.png, #45677
    2018-12-16 ttl StatusNone => Ready For Test

    Back to the top


    Powered by Savane 3.5