bugGNU Octave - Bugs: bug #54877, Documentation pane should have...

 
 

bug #54877: Documentation pane should have text zoom buttons

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Mon 22 Oct 2018 07:55:15 PM UTC  
 
Category:  GUI Severity:  1 - Wish
Priority:  3 - Low Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Philip Nienhuis Open/Closed:  Closed
Release:  dev Operating System:  Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 05 Nov 2018 04:27:49 PM UTC, comment #15:

Zoom buttons have been added in the course of bug #54938, so closing this report.

Philip Nienhuis <philipnienhuis>
Project Member
Fri 02 Nov 2018 08:22:12 AM UTC, comment #14:

OK, see bug #54938.

FTM I'll just lower priority

Philip Nienhuis <philipnienhuis>
Project Member
Thu 01 Nov 2018 06:10:26 PM UTC, comment #13:

Philip, I have to agree that most programs offering shortcuts for zooming also provide menu entries or other alternative means.

The additional features discussed in the previous comments would require a toolbar anyways. Then we can also add zoom buttons.

Torsten <ttl>
Project Member
Thu 01 Nov 2018 04:47:27 PM UTC, comment #12:

@Panxto:
Some more browser-bells & whistles are nice of course but then I'm a bit hesitant to ask as I suppose developer time had better be spent on more urgent things.
But if you insist / agree that some more buttons would be great, I'm happy to enter a new feature request. Just confirm.

BTW browsers may not have zoom buttons but all the ones I know & use have some form of zoom command in the toolbar menu, usually through View | Zoom....

Philip Nienhuis <philipnienhuis>
Project Member
Thu 01 Nov 2018 03:31:07 PM UTC, comment #11:

@Philip: I agree that a few more features, including e.g. previous/next-page buttons, browse history ... wouldn't hurt, but for zoom buttons, there is no such thing in any of the browsers I have used.
Can you post a new feature request to add web-browser-like features?

Pantxo Diribarne <pantxo>
Project Member
Wed 31 Oct 2018 05:28:36 PM UTC, comment #10:

@Panxto:
I'm unsure if the average use realizes that the documentation pane's engine is a browser-like thing and expected to be used as such.
But if it were a real browser I'd expect that also other usual browser key would work, e.g., the Backspace key would work as "Back" button, etc. That doesn't, so IMO zoom buttons wouldn't hurt.

Going on with the browser analogy I'd also like bookmarks (very useful).

Philip Nienhuis <philipnienhuis>
Project Member
Wed 31 Oct 2018 04:28:28 PM UTC, comment #9:

@Torsten: Yes, works great.

@Philip: Can we close this report or do you still want to keep it open as a feature request for actual zoom buttons in addition to shortcuts?

Pantxo Diribarne <pantxo>
Project Member
Tue 30 Oct 2018 10:15:56 PM UTC, comment #8:

Changeset http://hg.savannah.gnu.org/hgweb/octave/rev/49ffd0e0242d reimplements the mouse wheel event and uses the new internal methods for zooming by mouse wheel. This allows to reset the zoom level to normal by the assigned shortcut.

Torsten <ttl>
Project Member
Tue 30 Oct 2018 08:45:55 PM UTC, comment #7:

@Pantxo, good point. Reimplementing the wheel event shouldn't be a big deal, I am going to have a look at it. However, I am really wondering why there is no method for resetting or reading the current zoom level.

Torsten <ttl>
Project Member
Tue 30 Oct 2018 11:23:21 AM UTC, comment #6:

@Torsten: The patch works for me. The only minor issue is that CTRL+MouseWheelScrollUp/Down won't update the m_zoom_level, so that CTRL+"." does nothing after zooming with the mouse wheel. This is not an important issue since we don't claim to support mouse wheel actions. Unless we want to do something about this issue I think this report can be closed.

Pantxo Diribarne <pantxo>
Project Member
Mon 29 Oct 2018 08:40:43 PM UTC, comment #5:

The shortcuts Ctrl++ and Ctrl+- were not yet implemented for the doc browser and were not working on my ubuntu system either. Changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/a7cc5b7a3d22
adds the same configurable shortcuts as used for zooming in/out and resetting the zoom level in the editor.

Torsten <ttl>
Project Member
Tue 23 Oct 2018 05:48:46 PM UTC, comment #4:

From this bug report and bug #54879 I get the impression that shortcuts do not work at all in the Documentation pane under Windows.

Philip Nienhuis <philipnienhuis>
Project Member
Tue 23 Oct 2018 05:41:44 PM UTC, comment #3:

Thanks Panxto, but:

  • Ctrl-"+" and Ctrl-"-" don't work on Windows.
  • Ctrl-mousewheel does work but I wonder how that'll go on a (Windows) laptop with merely a trackpad.
Philip Nienhuis <philipnienhuis>
Project Member
Tue 23 Oct 2018 07:55:56 AM UTC, comment #2:

Just in case you did not notice, there is a simple wortkaround which is to use the same shortcuts as in Firefox:

  • zoom-in/out: Ctrl+"+", Ctrl+"-" or equivalently with the mouse Ctrl+MouseWheelScrollUp and Ctrl+MouseWheelScrollDown
  • previous/next page: Alt+LeftArrow and Alt+RightArrow

I never use a button to change the font size in an html browser so I would not use a button in Octave either (but that is my own practice). It would be nice though to have the doc browser shortcuts integrated into the shortcut manager. AFAIU, the shortcuts I mentioned above are currently the result of using Qt's default shortcuts for QTextBrowser.

Pantxo Diribarne <pantxo>
Project Member
Mon 22 Oct 2018 09:14:22 PM UTC, comment #1:

There isn't any pref for this either; in fact there's no preferences tab at all for the documentation pane.

Philip Nienhuis <philipnienhuis>
Project Member
Mon 22 Oct 2018 07:55:15 PM UTC, original submission:

If the subject line is unclear:
Under at least Windows, the documentation pane used to have zoom buttons (+, -) for making the text larger or smaller. Nowadays these buttons are missing.

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-11-05 philipnienhuis StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2018-11-02 philipnienhuis Severity3 - Normal => 1 - Wish
        Priority5 - Normal => 3 - Low
    2018-10-30 pantxo Operating SystemMicrosoft Windows => Any
    2018-10-29 ttl StatusNone => Ready For Test

    Back to the top


    Powered by Savane 3.4