bugGNU Octave - Bugs: bug #54701, [octave forge] (signal) butter:...

 
 

bug #54701: [octave forge] (signal) butter: Improve docstring format and argument processing

Submitter:  John W. Eaton <jwe>
Submitted:  Thu 20 Sep 2018 08:22:30 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Matlab Compatibility
Status:  Fixed Assigned to:  None
Originator Name:  jwe Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 21 Sep 2018 11:57:16 AM UTC, comment #3: 

Thanks for the quick response!

John W. Eaton <jwe>
Group administrator
Thu 20 Sep 2018 08:58:19 PM UTC, comment #2: 

Thanks for the patch and bug report. The doc string was very out of date and hard to read. I merged the commit message lines together since I follow the changelog style from Octave and pushed it, will go into the next bug fix release 1.4.1 (which is already a bit overdue).

http://hg.code.sf.net/p/octave/signal/rev/afe00992553f

Mike Miller <mtmiller>
Group Member
Thu 20 Sep 2018 08:23:48 PM UTC, comment #1: 

Patch attached.

(file #45066)

John W. Eaton <jwe>
Group administrator
Thu 20 Sep 2018 08:22:30 PM UTC, original submission:  

I noticed that the butter function doesn't accept "bandpass", that it doesn't set the default filter type depending on the number of elements given for the cutoff frequency, and that it could accept arguments out of order compared to Matlab.

I'll attach a patch with these changes and some doc updates after I get a bug number.

John W. Eaton <jwe>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #45066:  butter-diffs.txt added by jwe (8KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-09-21 mtmiller StatusNone Fixed
        Open/ClosedOpen Closed
    2018-09-21 jwe StatusFixed None
        Open/ClosedClosed Open
    2018-09-20 mtmiller StatusNone Fixed
        Open/ClosedOpen Closed
    2018-09-20 jwe Attached File- Added butter-diffs.txt, #45066

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code