bugGNU Octave - Bugs: bug #54383, accuracy issues with betainc

 
 

bug #54383: accuracy issues with betainc

Submitter:  John W. Eaton <jwe>
Submitted:  Thu 26 Jul 2018 12:59:26 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Inaccurate Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Solaris/SunOS
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 10 Jan 2019 03:11:14 AM UTC, comment #4: 

I increased the tolerance to -7e-14.  Marking as fixed and closing report.

Rik <rik5>
Group administrator
Wed 09 Jan 2019 08:53:26 PM UTC, comment #3: 

I confirm the tolerance was chosen just to be the smallest passing on my PC. It can be made a bit larger (I think that 8e-14 can still be considered quite good).

Michele Ginesi <m_ginesi>
Mon 30 Jul 2018 11:35:07 PM UTC, comment #2: 

Is this still failing?  Go ahead and just up the tolerance.  Try -7e-14 to start, and -8e-14 if that doesn't work.

Rik <rik5>
Group administrator
Thu 26 Jul 2018 07:25:09 PM UTC, comment #1: 

The tolerances were chosen based on the most restrictive values that still passed on Michele Ginesi's computer.  Some of the tolerances were relaxed in this cset (https://hg.savannah.gnu.org/hgweb/octave/rev/f80e68529bbf) in order to have the test suite pass on other i386 platforms.  Mike was the author of that cset.  I think it would probably be fine to just increase the tolerance for this single test.  The two tests are


%!assert <54383> (betainc (0.99, 20, 30, "upper"), 1.5671643161872703e-47, -5e-14);
%!assert (betainc (0.999, 20, 30, "upper"), 1.850806276141535e-77, -7e-14);


and the second one already has a larger tolerance.

Rik <rik5>
Group administrator
Thu 26 Jul 2018 12:59:26 PM UTC, original submission:  

The following test fails on Solaris:


>>>>> processing /export/home/eaton/local/src/octave-4.4.1-rc1/scripts/specfun/betainc.m
***** assert (betainc (0.99, 20, 30, "upper"), 1.5671643161872703e-47, -5e-14);
!!!!! test failed
ASSERT errors for:  assert (betainc (0.99, 20, 30, "upper"),1.5671643161872703e-47,-5e-14)

  Location  |  Observed  |  Expected  |  Reason
     ()       1.5672e-47   1.5672e-47    Rel err 7.4144e-14 exceeds tol 5e-14 by 2e-14


John W. Eaton <jwe>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by m_ginesi (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by rik5
  • -email is unavailable- added by jwe (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-01-10 rik5 StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2018-07-26 rik5 StatusNone In Progress
        Carbon-Copy- Added mtmiller

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code