bugGNU Octave - Bugs: bug #54372, camlight (axis_handle, ...) should...

 
 

bug #54372: camlight (axis_handle, ...) should work for Matlab Compatibility

Submitter:  Guillaume <gyom>
Submitted:  Wed 25 Jul 2018 10:08:50 AM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Matlab Compatibility
Status:  Fixed Assigned to:  None
Originator Name:  Guillaume Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 26 Jul 2018 09:46:03 PM UTC, comment #3: 

I modified it a bit to avoid calling isgraphics which will help with performance.  I pushed the changeset to the default branch under your name (https://hg.savannah.gnu.org/hgweb/octave/rev/b6f3e8ce6815).  Thanks for that patch.

Marking this as fixed and closing report.

Rik <rik5>
Group administrator
Thu 26 Jul 2018 08:50:38 AM UTC, comment #2: 

Thanks, Rik. I attach a possible patch that adds this feature. I think it might also fix another problem whereby a light object was passed as first argument but some axes properties were read from the current axes instead of the axes containing the light object.

(file #44624)

Guillaume <gyom>
Wed 25 Jul 2018 04:14:48 PM UTC, comment #1: 

Confirmed.  I don't know if this is a new feature or not, but it shouldn't be difficult to implement.  Most of the plot routines can accept an axis handle as the first argument and there is a specific function for getting it.  See plot.m for an example of usage


  [hax, varargin, nargs] = __plt_get_axis_arg__ ("plot", varargin{:});




Rik <rik5>
Group administrator
Wed 25 Jul 2018 10:08:50 AM UTC, original submission:  

camlight() does not accept a handle to an axis as first argument and always use gca().

https://www.mathworks.com/help/matlab/ref/camlight.html

Guillaume <gyom>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #44624:  camlight_patch.diff added by gyom (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by gyom (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-07-26 rik5 StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2018-07-26 gyom Attached File- Added camlight_patch.diff, #44624
    2018-07-25 rik5 StatusNone Confirmed
        Summaryaxis handle as an input to camlight camlight (axis_handle, ...) should work for Matlab Compatibility

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code